Skip to content
This repository has been archived by the owner on Mar 20, 2021. It is now read-only.

support mysql (5.6, 5.7, 8.0) and user defined metrics (UDM) #400

Merged
merged 19 commits into from
May 11, 2020
Merged

support mysql (5.6, 5.7, 8.0) and user defined metrics (UDM) #400

merged 19 commits into from
May 11, 2020

Conversation

bohanjason
Copy link
Contributor

@bohanjason bohanjason commented Apr 23, 2020 •
edited
Loading

  1. support MySQL 5.6, 5.7, 8.0
  2. support remote_docker mode in driver
  3. more log info for debugging
  4. add user defined metrics (UDM) in driver. These metrics are collected by the driver, but do not exist in target database. The user defined metric can be the target objective. For example, we want to use 99percent latency as the target objective. We can cannot find such metric in the target database, but we get it from OLTP-Bench. So the driver can upload such metric as UDM.

Issue: #401 #402 #403

@bohanjason bohanjason changed the title support mysql5.6 support mysql (5.6, 5.7, 8.0) and user defined metrics (UDM) Apr 28, 2020
@bohanjason
Copy link
Contributor Author

Ready for reviewing. Tested locally.

@dvanaken dvanaken requested a review from yangdsh April 30, 2020 17:28
yangdsh
yangdsh approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@yangdsh yangdsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

server/website/website/views.py Outdated Show resolved Hide resolved
server/website/website/views.py Outdated Show resolved Hide resolved
server/website/website/db/base/target_objective.py Outdated Show resolved Hide resolved
@bohanjason bohanjason closed this May 5, 2020
@bohanjason bohanjason reopened this May 5, 2020
@bohanjason bohanjason requested a review from yangdsh May 5, 2020 20:21
yangdsh
yangdsh approved these changes May 5, 2020
View reviewed changes
server/website/website/views.py
Comment on lines +497 to +499
if target_instance.is_udf() and len(udm_all) == 0:
return HttpResponse('ERROR: user defined target objective {} is not uploaded!'.format(
target_name))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is the same as the below part. You might want to change the message to 'No user_defined_metrics uploaded'.

yangdsh
yangdsh reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@yangdsh yangdsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now a udm needs to be selected on the website to be the target objective, is that correct?

server/website/website/db/base/target_objective.py Outdated Show resolved Hide resolved
@dvanaken
Copy link
Collaborator

@bohanjason @yangdsh is this ready to merge?

@bohanjason
Copy link
Contributor Author

@dvanaken , I think so. It can be merged

@dvanaken
Copy link
Collaborator

Ok, great. Thanks @bohanjason for adding support for MySQL this is awesome! And thanks @yangdsh for reviewing!

@dvanaken dvanaken merged commit 1a74cac into cmu-db:master May 11, 2020
This was referenced May 13, 2020
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yangdsh yangdsh yangdsh approved these changes

@dvanaken dvanaken Awaiting requested review from dvanaken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bohanjason @dvanaken @yangdsh