This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Fix for optimizer rule bug #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtunique
pushed a commit
to mtunique/peloton
that referenced
this pull request
Apr 16, 2019
* False negative in rule bug * Fix for false positive rule bug * Remove print
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false positive in rule checking (#1234). The error was being caused by incorrect use of
bitmap.setfunction. I also added a plan printing helper function. Lastly, I improved our group expression equality function. While it's not a complete fix to #1354, it helps.@apavlo For some reason PR #1245 never got checked in (it says merged but the changes aren't in the code), so I'm submitting this one. We never merged in my PR for the class (#1344), however, that also included the bug fixes we found during the semester. I'm gonna add those in separate PRs like this one.