-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reframe() instead of summarize() for multiple rows #620
Conversation
Fix `problem_dates` check when fetching actual data from API
…roup Remove duplicate join in `evaluate_covid_predictions`
…val-preds-group Revert "Remove duplicate join in `evaluate_covid_predictions`"
Get unit tests to pass on `evalcast` branch
Retry forecaster file download if prior attempts fail
…neral Forecast eval support: make retries more general
* add honest_as_of flag * add parallel_execute flag
Retry truth data request from COVIDcast if prior attempts fail
My memory is that the reason it's not on Longer term, I would suggest that any packages that are still useful to be moved out of subfolders in this repo into their own repos. And perhaps kill off stale junk. |
The failed evalcast test is potentially concerning. But @nmdefries is more up to speed on that package's status. |
Before covidcast was on CRAN, we were certainly worried that most people installed from GitHub, so changes would immediately be visible to users. Does evalcast get used by outsiders in that way, or is everyone using evalcast also involved in development? We can also update the CODEOWNERS file if it's constantly requiring unnecessary reviews. It's probably worth reviewing it anyway, as several people have left. |
Pinging @lcbrooks for evalcast usage input. I have a hunch that we're the only ones using it, but maybe not. The current |
I'm not aware of other people who are using [Guess I should have also checked for DESCRIPTION files / etc. to see if there are packages that depend on evalcast. But the main one to check is covidHubUtils but it also doesn't use evalcast, so I'm guessing there aren't.] |
Evalcast: fix bettermc remote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEOWNERS and CI workflow look solid; minor question on working directory settings
Evalcast: set get_predictions default to parallel=FALSE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ci changes approved
@@ -94,4 +94,4 @@ Suggests: | |||
VignetteBuilder: | |||
utils | |||
Depends: | |||
R (>= 3.5.0) | |||
R (>= 4.1.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a hot second I was extremely confused, because the CI changes from this commit block are for covidcast, and this version dependency change is for evalcast
but i've confirmed that the only R version in the evalcast ci is 4.1, so this change should work fine with ci
Since dplyr 1.1.0, returning multiple rows from summarize() is deprecated, and you're supposed to use reframe() instead. These are our two use-cases, so switch them over.
I ran into this while updating an old presentation, and dplyr helpfully barfed the deprecation warning right into my slides. This should fix it.