Evalcast: set get_predictions default to parallel=FALSE #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
requested review from
jacobbien,
dajmcdon,
krivard and
capnrefsmmat
as code owners
brookslogan
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this was set to TRUE, but using parallelism for forecasting is quite tricky due to the many levels where it can be implemented. We've had too many times in production forecasting where eager parallelism settings at a lower level caused memory or other performance issues. Setting the default to FALSE is the safer option.
Some things to look out for with this change:
The CI is going to fail due to Python tests getting fixed in #620.