-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Djm/autoplot #382
Merged
Merged
Djm/autoplot #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookslogan
reviewed
Jan 18, 2024
nmdefries
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to get a some of autoplot
behavior to work. Specifics below.
thought: Could be nice to be able to change the color scheme. That may be too feature-ful for |
…r didn't pass col names
Using an external vector in selections was deprecated in tidyselect 1.1.0. i Please use `all_of()` or `any_of()` instead. # Was: data %>% select(geo_and_other_keys) # Now: data %>% select(all_of(geo_and_other_keys))
refactor: use checkmate checks
Test autoplot and arg-checker functions
@brookslogan Trying to document to regenerate the NAMESPACE. I'm hitting: devtools::document()
ℹ Updating epiprocess documentation
ℹ Loading epiprocess
Error: 'archive_cases_dv_subset' is not an exported object from 'namespace:epiprocess' Followed by: devtools::document()
ℹ Updating epiprocess documentation
ℹ Loading epiprocess
Error in `withCallingHandlers()` at epiprocess/R/data.R:137:7:
! An error was raised while attempting to evaluate a promise (prepared
with `delayed_assign_with_unregister_awareness`) while an `unregister` or
`unregister_namespace` call was being evaluated. This can happen, for example,
when `devtools::load_all` reloads a package that contains a buggy promise,
because reloading can cause old package-level promises to be forced via
`pkgload::unregister` and `pkgload:::unregister_namespace`, due to
https://github.com/r-lib/pkgload/pull/157. If this is the current situation,
you might be able to be successfully reload the package again after
`unloadNamespace`-ing it (but this situation will keep re-occurring every
other `devtools::load` and every `devtools:document` until the bug or
situation generating the promise's error has been resolved).
Caused by error in `as.data.table()`:
! could not find function "as.data.table"
Run `rlang::last_trace()` to see where the error occurred. |
nmdefries
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
autoplot()
functionality and some helpers.Needs #377 to pass checks.
See also