Fix guess_period on datetimes, make it more precise + generic #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't discard units and effectively replace them with seconds - Don't allow any tolerance in judging a remainder to be zero, since when we use it to generate the default `ref_time_values` that means we could miss reproducing some of the actual input time values. - Make it into an S3 generic so it can be extended for more time classes.
nmdefries
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
This is to fix
guess_period()on regularly-spaced datetimes, fixingepix_slide_ref_time_values_default()on regularly-spaced datetime versions... though the latter are going to be super rare actually. We might want to make some other changes, but it's probably worth throwing in this bugfix anyway in case thinking about alternative default time values takes a while.Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
epix_slide_ref_time_values_defaultmisbehaves on datetimes #447