Fix bivariate #139
Closed
Fix bivariate #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase off main so that ONLY the new commit(s) are in this PR? When you make the change make sure you branch off main rather than an old branch |
willeppy
requested changes
Jul 3, 2023
digautoprofiler/profile_lib.py
Outdated
| @@ -306,19 +296,3 @@ def getTempAggrData(dfName: pd.DataFrame, tempColName: str, quantColName: str, a | |||
| tempAggrData = groups.max() | |||
| print(json.dumps({"data":tempAggrData.to_dict(), "timestep":timestep})) | |||
|
|
|||
|
|
|||
|
|
|||
| def hampel(colData: pd.Series, k=7): | |||
There was a problem hiding this comment.
Rebase off main, this should not get deleted
| @@ -282,7 +272,7 @@ def getTempAggrData(dfName: pd.DataFrame, tempColName: str, quantColName: str, a | |||
| offsetAliases = ['Y','M','W','D','H','T','S'] | |||
| i = 0 | |||
| previousLen = -float("inf") | |||
| currentLen = 0 | |||
| currentLen = len(dfName[tempColName].dt.to_period(offsetAliases[i]).unique()) | |||
There was a problem hiding this comment.
I find the initial value of currentLen is wrong, which is the reason why the temporal chart sometimes can not determine the number of bins well
| @@ -254,16 +253,7 @@ def getTemporalMeta(colData: pd.Series): | |||
| result = "descending" | |||
| else: | |||
| result = "noSort" | |||
| vc = colData.value_counts() | |||
There was a problem hiding this comment.
Rebase off main, this should not get deleted
yuqizhang99
force-pushed
the
fix_bivariate
branch
from
dd7f0b9
to
1dc88dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality
fix the function of automatically determining the number of bins for temporal chart