Fix endianness issues in binary trie LM code #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really don't understand the point of this code, and I'm still not certain it really works on big-endian archs. The "ARM" versions of the code are correct for all architectures because a good complier will inline and optimize away memcpy() and this avoids aliasing problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests should now pass on S390, and, presumably, other big-endian machines. Should notably fix #252
I don't know who wrote the bitarr and lm_trie code but I would like a word with them. It is undocumented and inscrutable and the fact that it is full of assumptions that make it break on other architectures doesn't give me confidence in its correctness or security.