Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert incorrect optimizations to JSGF compiler (fixes #53) #305

Merged
merged 8 commits into from
Sep 29, 2022

Commits on Sep 28, 2022

  1. revert: jsgf optimization that created incorrect grammars

    Original commit was cmusphinx/sphinxbase@e59cac4
    
    The resulting FSGs are, yes, quite bad, but the optimization was incorrect, and the
    proposed fix for it did not actually fix the problem, but made the code more
    complex.  In general I think the Knuth quote about premature optimization is
    just an excuse for people to write bad code, but in this case it seems pertinent
    dhdaines committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    f633eae View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Configuration menu
    Copy the full SHA
    5360985 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5924352 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c76888 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f09c57 View commit details
    Browse the repository at this point in the history
  5. fix: get right recursion right right (right | right*)

    The change I reverted was *partially* correct as it noted that a right-recursive rule
    cannot reach the final state on its own, so put this change back
    dhdaines committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2f548ca View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c0a224c View commit details
    Browse the repository at this point in the history
  7. test: add test for fsg_model_accept

    with the side effect that it verifies the correctness of the
    tests in test-sphinx_jsgf2fsg.sh
    dhdaines committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    271a91e View commit details
    Browse the repository at this point in the history