Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec compliance] Need to replace "digest" with "contentDigest" in Images/InvocationImages #59

Closed
jeremyrickard opened this issue Jul 12, 2019 · 0 comments · Fixed by #75
Closed

[spec compliance] Need to replace "digest" with "contentDigest" in Images/InvocationImages #59

jeremyrickard opened this issue Jul 12, 2019 · 0 comments · Fixed by #75
Milestone
cnab-go 1.0

Comments

@jeremyrickard
Copy link
Member

Our BaseImage struct has JSON marshalling tags on the Digest field as follow:

Digest    string            `json:"digest,omitempty" mapstructure:"digest"`

The spec defines invocation images and images to have a contentDigest field, not a digest. We need to update to this.
@jeremyrickard jeremyrickard added this to the cnab-go 1.0 milestone Jul 22, 2019
jeremyrickard added a commit to jeremyrickard/cnab-go that referenced this issue Jul 23, 2019
@jeremyrickard
Switch digest to contentDigest in the json tags
966cda2 
This PR swaps `contentDigest` in place of `digest` in the json/mapstructure tags for the BaseImage type. Adds a test for marashalling as well.

Fixes cnabio#59
@jeremyrickard jeremyrickard mentioned this issue Jul 23, 2019
Merged
jeremyrickard added a commit to jeremyrickard/cnab-go that referenced this issue Jul 24, 2019
@jeremyrickard
Switch digest to contentDigest in the json tags
ff5d4c9 
This PR swaps `contentDigest` in place of `digest` in the json/mapstructure tags for the BaseImage type. Adds a test for marashalling as well.

Fixes cnabio#59
@glyn glyn closed this as completed in #75 Jul 24, 2019
glyn pushed a commit that referenced this issue Jul 24, 2019
@jeremyrickard @glyn
Switch digest to contentDigest in the json tags (#75)
098f359 
* Switch `digest` to `contentDigest` in the json tags

This PR swaps `contentDigest` in place of `digest` in the json/mapstructure tags for the BaseImage type. Adds a test for marashalling as well.

Fixes #59

* Updated code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
cnab-go 1.0
Development

Successfully merging a pull request may close this issue.

Switch digest to contentDigest in the json tags jeremyrickard/cnab-go
1 participant
@jeremyrickard