Fix panic when op.Err is unset in Docker driver #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
fix-stdcopy-panic
branch
from
3dfa9af
to
919a56b
Compare
carolynvs
force-pushed
the
fix-stdcopy-panic
branch
from
919a56b
to
9fbdce4
Compare
The op.Err field was added after the docker driver was first written. I noticed that when the caller of the docker driver doesn't set op.Err it causes a panic when we attach to the container's logs. This fixes our defaulting of where we write errors so that we are never writing to a nil writer accidentally. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
fix-stdcopy-panic
branch
from
9fbdce4
to
152b0db
Compare
vdice
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The op.Err field was added after the docker driver was first written. I noticed that when the caller of the docker driver doesn't set op.Err it causes a panic when we attach to the container's logs.
This fixes our defaulting of where we write errors so that we are never writing to a nil writer accidentally.
It is based on #279 so I will rebase after that is merged.