Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the BaseImage definition to replace platform with Labels #58

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Updated the BaseImage definition to replace platform with Labels #58

merged 2 commits into from
Jul 15, 2019

Conversation

jeremyrickard
Copy link
Member

@jeremyrickard jeremyrickard commented Jul 12, 2019 •
edited
Loading

Fixes #58

silvin-lubecki
silvin-lubecki approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
Copy link
Contributor

Oh just wondering, is the type ImagePlatform still used? https://github.com/deislabs/cnab-go/blob/5ca85500e801be695748cf1f360f2254f425d19c/bundle/bundle.go#L89
Maybe should we remove it if it's not the case?

@jeremyrickard
Copy link
Member Author

Oh just wondering, is the type ImagePlatform still used?

https://github.com/deislabs/cnab-go/blob/5ca85500e801be695748cf1f360f2254f425d19c/bundle/bundle.go#L89

Maybe should we remove it if it's not the case?

YES, good catch @silvin-lubecki

@jeremyrickard jeremyrickard merged commit 10de618 into cnabio:master Jul 15, 2019
@jeremyrickard jeremyrickard mentioned this pull request Jul 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glyn glyn glyn approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyrickard @silvin-lubecki @glyn