Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo structure for base vs project cluster components #27

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Jan 17, 2024

  • Create a falco namespace that will contain the Falco deployment + demo workload.
  • Change repository structure to have:
    • clusters/projects/<cncf-project> for CNCF projects such as Falco etc. We can change this further in the future if needed.
    • clusters/base/<base-components> for Kepler, Prometheus, etc.
tree clusters
clusters
├── projects
│   └── falco
│       └── falco-namespace.yaml
├── base
│   ├── kepler-grafana.yaml
│   ├── kepler.yaml
│   └── kube-prometheus-stack.yaml
└── flux-system
    ├── gotk-components.yaml
    ├── gotk-sync.yaml
    └── kustomization.yaml

Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
@rossf7
Copy link
Contributor

rossf7 commented Jan 17, 2024

@nikimanoledaki What about using clusters -> projects -> CNCF project for the naming strategy?

Apps is also good but I think projects is clearer for our use case.

Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
@nikimanoledaki
Copy link
Contributor Author

@rossf7 very good point, renamed!

@nikimanoledaki nikimanoledaki changed the title Create Falco namespace Update repo structure for base vs project Flux apps Jan 17, 2024
@nikimanoledaki nikimanoledaki changed the title Update repo structure for base vs project Flux apps Update repo structure for base vs project cluster components Jan 17, 2024
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rossf7 rossf7 merged commit 86f136f into main Jan 17, 2024
1 check passed
@rossf7 rossf7 deleted the create-falco-namespace branch January 17, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants