Add SCI dashboard for Falco #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikimanoledaki
force-pushed
the
add-sci-dashboard
branch
6 times, most recently
from
07906c1
to
dc61836
Compare
Co-authored-by: raymundovr <raymundo.vr@protonmail.com> Signed-off-by: nikimanoledaki <niki.manoledaki@grafana.com>
nikimanoledaki
force-pushed
the
add-sci-dashboard
branch
from
dc61836
to
a382592
Compare
nikimanoledaki
requested review from
rossf7,
AntonioDiTuri,
guidemetothemoon and
leonardpahlke
rossf7
reviewed
Mar 12, 2024
There was a problem hiding this comment.
@nikimanoledaki @raymundovr This is awesome, great work!
I left some comments including with the value of M for the Equinix server.
| "sort": "none" | ||
| } | ||
| }, | ||
| "title": "Embodied (M) - Falco", |
There was a problem hiding this comment.
@nikimanoledaki the value of M for the m3.small we're using is 3.92 gCO2eq per 15 mins.
Could you add that?
See #73 for the write up
There was a problem hiding this comment.
I'll add this to the calculations :)
leonardpahlke
approved these changes
Mar 12, 2024
guidemetothemoon
approved these changes
Mar 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/feature
What this PR does / why we need it:
This PR adds the scaffolding for a Grafana dashboard that shows the SCI of Falco. There are still a few TODOs! I wanted to get early feedback on the progress @raymundovr and I have made so far.
The dashboard can be found here. Checkout the login info for the public Grafana instance here.
Which issue(s) this PR fixes:
Part of #38
Part of #39
^ not closing either until docs are added.
-->
Special notes for your reviewer (optional):
Will open a separate PR for adding info to docs :)