Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners for PR automation #82

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Apr 10, 2024

What type of PR is this?

kind/enhancement

What this PR does / why we need it:

Adds CODEOWNERS file to automate setting of reviewers in PRs

Which issue(s) this PR fixes:

None

Special notes for your reviewer (optional):

Hey @leonardpahlke @guidemetothemoon,
we would like to add this automation so its clear who should review PRs and so we can spread the reviews across the team.

Are you OK with this?

I'm also going to need some help to enable it as I don't have access to the branch protection settings.

Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@AntonioDiTuri
Copy link
Contributor

Looks good to me for the moment, maybe we can specify some rules later on :)

@AntonioDiTuri
Copy link
Contributor

I am waiting for your ack to merge @leonardpahlke, @guidemetothemoon if it is ok to be listed as reviewers :)

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use github groups and specify some files & folders

CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Leonard Vincent Simon Pahlke <58054077+leonardpahlke@users.noreply.github.com>
@rossf7
Copy link
Contributor Author

rossf7 commented Apr 10, 2024

@leonardpahlke Thank you, better to use the groups.

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonardpahlke leonardpahlke merged commit 023807a into cncf-tags:main Apr 10, 2024
1 check passed
@leonardpahlke
Copy link
Member

updated the repo settings:
Screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants