Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeVela-Logos links give 404s #301

Closed
chalin opened this issue Oct 23, 2021 · 3 comments · Fixed by #302
Closed

KubeVela-Logos links give 404s #301

chalin opened this issue Oct 23, 2021 · 3 comments · Fixed by #302

Comments

@chalin
Copy link
Contributor

chalin commented Oct 23, 2021

Visit https://github.com/cncf/artwork/blob/master/examples/sandbox.md#kubevela-logos and you'll see:

image

All of the horizontal images fail to render (due to 404s) as are some of the other PNGs.

@chalin
Copy link
Contributor Author

chalin commented Oct 23, 2021

/cc @amye @caniszczyk

@chalin
Copy link
Contributor Author

chalin commented Oct 23, 2021

The problem is that some of the artwork filenames have zero-width space characters in them, for example:

$ ls /projects/kubevela/horizontal/white | od -c -x
0000000    k   u   b   e   v   e   l   a   -   h   o   r   i   z   o   ​
             756b    6562    6576    616c    682d    726f    7a69    e26f
0000020   **  **   ​  **  **   n   t   a   l   -   w   h   i   t   e   .
             8b80    80e2    6e8b    6174    2d6c    6877    7469    2e65
0000040    p   n   g  \n   k   u   b   e   v   e   l   a   -   h   o   r
             6e70    0a67    756b    6562    6576    616c    682d    726f
0000060    i   z   o   ​  **  **   ​  **  **   n   t   a   l   -   w   h
             7a69    e26f    8b80    80e2    6e8b    6174    2d6c    6877
0000100    i   t   e   .   s   v   g  \n                                
             7469    2e65    7673    0a67                                
0000110

Note the ** in the names.

@chalin
Copy link
Contributor Author

chalin commented Oct 23, 2021

I've checked the enitre repo and only the KubeVela files have ZWSP characters in them:

# From artwork:
$ find . | grep "$(printf %b '\u200b')" 
./projects/kubevela/horizontal/Color/KubeVela-horizo​​ntal-color.svg
./projects/kubevela/horizontal/Color/kubevela-horizo​​ntal-color.png
./projects/kubevela/horizontal/white/kubevela-horizo​​ntal-white.png
./projects/kubevela/horizontal/white/kubevela-horizo​​ntal-white.svg
./projects/kubevela/horizontal/black/Kubevela-horizo​​ntal-black.png
./projects/kubevela/horizontal/black/kubevela-horizo​​ntal-black.svg

@chalin chalin changed the title KubeVela Logos links give 404s KubeVela-Logos links give 404s Oct 23, 2021
@amye amye closed this as completed in #302 Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant