-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KubeVela-Logos links give 404s #301
Comments
/cc @amye @caniszczyk |
The problem is that some of the artwork filenames have zero-width space characters in them, for example: $ ls /projects/kubevela/horizontal/white | od -c -x
0000000 k u b e v e l a - h o r i z o
756b 6562 6576 616c 682d 726f 7a69 e26f
0000020 ** ** ** ** n t a l - w h i t e .
8b80 80e2 6e8b 6174 2d6c 6877 7469 2e65
0000040 p n g \n k u b e v e l a - h o r
6e70 0a67 756b 6562 6576 616c 682d 726f
0000060 i z o ** ** ** ** n t a l - w h
7a69 e26f 8b80 80e2 6e8b 6174 2d6c 6877
0000100 i t e . s v g \n
7469 2e65 7673 0a67
0000110 Note the |
I've checked the enitre repo and only the KubeVela files have ZWSP characters in them: # From artwork:
$ find . | grep "$(printf %b '\u200b')"
./projects/kubevela/horizontal/Color/KubeVela-horizontal-color.svg
./projects/kubevela/horizontal/Color/kubevela-horizontal-color.png
./projects/kubevela/horizontal/white/kubevela-horizontal-white.png
./projects/kubevela/horizontal/white/kubevela-horizontal-white.svg
./projects/kubevela/horizontal/black/Kubevela-horizontal-black.png
./projects/kubevela/horizontal/black/kubevela-horizontal-black.svg |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Visit https://github.com/cncf/artwork/blob/master/examples/sandbox.md#kubevela-logos and you'll see:
All of the horizontal images fail to render (due to 404s) as are some of the other PNGs.
The text was updated successfully, but these errors were encountered: