Allowing to configure if you wish the process to exit when blacklisted #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. Changes look good, but instead of |
|
Will do update this now. Not had chance to get some code done over the last week. |
|
Oh, I see you updated this: 4cfc9e1 |
|
Sorry about that, forgot to update you! I merged your changes though since they were basically complete and just renamed the stuffs. I'll publish later. |
|
I'll make sure to update the console.log that you added too so thanks for that |
cnguy
added a commit
that referenced
this pull request
Jun 8, 2018
cnguy
added a commit
that referenced
this pull request
Jun 8, 2018
|
Published to 0.8.15! Thank you once again for the work + suggestion. @Scotsoo |
|
No worries. Yeah, I realised the console.log wouldn't log cause the process would've exited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not too keen on the process exiting when my API key is invalid ect. This should be configurable as far as I'm concerned.