Multi taper #23
Open
Multi taper #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah, didn't see that this should have been merged first. Sorry about that. |
|
No worries. Let me see if I can rebase this. |
|
Meaning - I actually meant this should not be merged yet - so you did everything in the right order. No worries 👍 |
|
Don't merge this one yet. Please. |
|
ah, should NOT be merged. Phew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables an option to use methods other than the straight FFT for spectral analysis. In particular, multi-taper spectral analysis can help achieve better spectral resolution, for example for separating choline and creatine signals. But I am not sure that SNR is well-preserved... Need to experiment more with this.
At any rate, this should not be merged before the two lorentz PR (#22)
Once two-lorentz lands, we can revisit this one as well.