-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support auto fix bug version of package #256
Conversation
bin/install.js
Outdated
@@ -234,6 +241,14 @@ co(function* () { | |||
}; | |||
} | |||
|
|||
if (argv['package-version-mapping-file']) { | |||
const packageVersionMapping = yield utils.readJSON(argv['package-version-mapping-file']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样只能是本地文件了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tnpm install 之前下载到本地?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/cnpm/bug-versions 不下载,去读 registry 里面拿到 package.json 的配置,然后写到 node_modules/.xxx 文件里面
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么不直接 npminstall 读好了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,改成 npminstall 内置功能。
@dead-horse https://github.com/cnpm/bug-versions 目前是没有内置的,在 tnpm 配置此文件参数。 |
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 89.95% 90.18% +0.22%
==========================================
Files 27 27
Lines 1732 1742 +10
Branches 288 290 +2
==========================================
+ Hits 1558 1571 +13
+ Misses 174 171 -3
Continue to review full report at Codecov.
|
use `--fix-bug-versions` to enable this feature.
09a59f6
to
8c53d04
Compare
@dead-horse 重构了,直接 npminstall 内置,默认不打开。 |
3.3.0 |
use
--fix-bug-versions
to enable this feature.This change is