feat: support --no-optional on install process #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=========================================
- Coverage 92.83% 92.8% -0.04%
=========================================
Files 27 27
Lines 1912 1917 +5
Branches 323 325 +2
=========================================
+ Hits 1775 1779 +4
- Misses 137 138 +1
Continue to review full report at Codecov.
|
fengmk2
commented
Nov 21, 2018
| // link every packages' latest version to target directory | ||
| yield linkAllLatestVersion(rootPkgsMap, options); | ||
| // don't link latest versions on `npminstall pkgName` way | ||
| if (options.pkgs.length === 0) { |
dead-horse
reviewed
Nov 22, 2018
| all[name] = optionalDependencies[name]; | ||
| prod[name] = optionalDependencies[name]; | ||
| if (options.ignoreOptionalDependencies) { | ||
| delete all[name]; |
There was a problem hiding this comment.
如果在 dependencies 和 optionalDependencies 中都有，也会被删掉么？npm 是这样处理的？
|
yarn 叫 ignore-optional |
Don’t install optional dependencies. like yarn does: https://yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-ignore-optional
fengmk2
force-pushed
the
ignore-optional
branch
from
3fee87d
to
00accc3
Compare
fengmk2
changed the title
|
node 4 挂了 |
|
3.16.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t install optional dependencies.
like yarn does: https://yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-ignore-optional