Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make npa error more clear #352

Merged
merged 6 commits into from
Aug 12, 2021
Merged

fix: make npa error more clear #352

merged 6 commits into from
Aug 12, 2021

Conversation

gemwuu
Copy link
Member

@gemwuu gemwuu commented Aug 9, 2021

PR for npa(#63)

@gemwuu gemwuu requested a review from killagu August 9, 2021 13:25
lib/npa.js Show resolved Hide resolved
lib/npa.js Outdated Show resolved Hide resolved
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nested 在调用链路里面改动太多了,建议新增一个安装上下文。未来新增字段去修改上下文即可。

@gemwuu
Copy link
Member Author

gemwuu commented Aug 11, 2021

nested 在调用链路里面改动太多了,建议新增一个安装上下文。未来新增字段去修改上下文即可。

resolved.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 6166be2 into master Aug 12, 2021
@killagu killagu deleted the feat/npa-error branch August 12, 2021 05:30
@killagu
Copy link
Contributor

killagu commented Aug 12, 2021

+ npminstall@5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants