fix(provider): update join k3d function and rollback logic #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JacieChao I am not authorized to access the Drone CI platform, so I do not know how to fix the above problem. |
@sunyakun |
JacieChao
reviewed
Jul 14, 2023
pkg/cluster/base.go
Outdated
| } | ||
| if state.Status != common.StatusRunning { |
There was a problem hiding this comment.
We also need to check state != nil to avoid the cluster not found situation.
sunyakun
force-pushed
the
fix/k3d-provider
branch
from
6bec669
to
e0af073
Compare
JacieChao
approved these changes
Jul 14, 2023
|
感谢sun对开源世界的贡献，母校为他骄傲。 |
|
@sunyakun Thanks for your contribution. PR Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the issue #615
node.Rollbackto true, this will enable automatic rollback of the k3d cluster in case of any errors.