Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QUICK-INSTALL.md #625

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Update QUICK-INSTALL.md #625

merged 1 commit into from
Feb 23, 2021

Conversation

wvwatson
Copy link
Collaborator

CNF Conformance PR Template

Description

(name of issue/change)

Issues:

Refs: #NNN

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

agentpoyo
agentpoyo requested changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get produce results using our example CNF should be This should produce results using our example CNF

@agentpoyo agentpoyo merged commit a165ad7 into docs/private_docker_registry_#577_#606 Feb 23, 2021
@taylor taylor deleted the wavell-patch-1 branch April 13, 2021 15:27
@taylor taylor mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agentpoyo agentpoyo agentpoyo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wvwatson @agentpoyo