Support GHC 9.2. #14
Merged
Support GHC 9.2. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anyway we can merge this ? |
teto
reviewed
Sep 10, 2022
|
|
||
| source-repository head | ||
| type: git | ||
| location: https://github.com/co-log/co-log-polysemy.git | ||
|
|
||
| common common-options | ||
| build-depends: base >= 4.11 && < 4.16 | ||
| build-depends: base >= 4.11 && < 4.17 |
There was a problem hiding this comment.
can't we just get rid of the upperbound ? updating haskell compiler is such a chore because of this.
There was a problem hiding this comment.
You are right - I did the same PR for ghc 9.4 now - but I wouldn't like to decide if we should remove upper bounds (there are pro's and con's). @vrom911 What do you think? Should I remove the upper bounds in #16 to avoid the necessity to just adapt the meta-data of the package for every new GHC release in the future?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #4