Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cEP-0028: Optimizing coala for language server #171

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

ksdme
Copy link
Member

@ksdme ksdme commented Jul 1, 2018

This proposal describes techniques to optimize coala language server.

Closes #156

cEP-0028.md Outdated
cls_enabled = False
bears = SomeLongRunningBear
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -54,7 +54,7 @@
     cls_enabled = False
     bears = SomeLongRunningBear
    ```
-   
+
    This kind of a configuration will disable the bear completely for invocations
    of coala via a language server while enabling it for regular invocations.
 

cEP-0028.md Outdated

The following functions are core to the current general cli entry point and
need to be patched as part of the custom coala language server entry point
for:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -107,7 +107,7 @@
 
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point
-   for: 
+   for:
    - `coalib.processes.Processing.get_file_dict()` 
    - `coalib.processes.Processing.execute_section()`
    - `coalib.coala_main.run_coala()`

cEP-0028.md Outdated
The following functions are core to the current general cli entry point and
need to be patched as part of the custom coala language server entry point
for:
- `coalib.processes.Processing.get_file_dict()`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -108,7 +108,7 @@
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point
    for: 
-   - `coalib.processes.Processing.get_file_dict()` 
+   - `coalib.processes.Processing.get_file_dict()`
    - `coalib.processes.Processing.execute_section()`
    - `coalib.coala_main.run_coala()`
 

cEP-0028.md Outdated
- `coalib.coala_main.run_coala()`

The prototypes for functions that will replace/patch those are:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -113,7 +113,7 @@
    - `coalib.coala_main.run_coala()`
 
    The prototypes for functions that will replace/patch those are:
-   
+
    ```python
     def get_file_dict(filename_list,
                       fileproxy_map,

cEP-0028.md Outdated
@@ -0,0 +1,146 @@
# Optimizing coala for language server

| Metadata | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -1,13 +1,13 @@
 # Optimizing coala for language server
 
-| Metadata |                                            |
-| -------- | ------------------------------------------ |
-| cEP      | 0028                                       |
-| Version  | 0.1                                        |
-| Title    | Optimizing coala for language server       |
-| Authors  | Kilari Teja <mailto:ksdme9@gmail.com>      |
-| Status   | Proposed                                   |
-| Type     | Process                                    |
+| Metadata |                                       |
+| -------- | ------------------------------------- |
+| cEP      | 0028                                  |
+| Version  | 0.1                                   |
+| Title    | Optimizing coala for language server  |
+| Authors  | Kilari Teja <mailto:ksdme9@gmail.com> |
+| Status   | Proposed                              |
+| Type     | Process                               |
 
 ## Abstract
 

cEP-0028.md Outdated
cls_enabled = False
bears = SomeLongRunningBear
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -54,7 +54,7 @@
     cls_enabled = False
     bears = SomeLongRunningBear
    ```
-   
+
    This kind of a configuration will disable the bear completely for invocations
    of coala via a language server while enabling it for regular invocations.
 

cEP-0028.md Outdated

This example shows a configuration where the section is disabled for coala
but will only be enabled when the code editor dispatches a request of type
```textDocuemnt/didSave```.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -68,29 +68,31 @@
 
    This example shows a configuration where the section is disabled for coala
    but will only be enabled when the code editor dispatches a request of type
-   ```textDocuemnt/didSave```.
+   `textDocuemnt/didSave`.
 
    ### Supported Parameters
+
    The following are the supported parameter types:
-    - `cls_enabled`: A boolean indicating if the section should be enabled.
-    Disabling the section will turn if off for coala lang server. It will
-    default to true.
 
-    - `cls_on`: A list containing some or all of the available options,
-    `every`, `open`, `save`, `change`, `formatting`. This indicates the
-    type of request(s) the section should be executed on. `cls_on` will
-    default to `all`.
+   - `cls_enabled`: A boolean indicating if the section should be enabled.
+     Disabling the section will turn if off for coala lang server. It will
+     default to true.
 
-    - `cls_fixes_enabled`: A boolean value indicating if the code fixes
-    generated by the section should be sent to the editor for being applied.
-    Initially only `formatting` request will respond with code fixes.
+   - `cls_on`: A list containing some or all of the available options,
+     `every`, `open`, `save`, `change`, `formatting`. This indicates the
+     type of request(s) the section should be executed on. `cls_on` will
+     default to `all`.
 
-    - `cls_as_global`: A boolean flag indicating if the section should be
-    considered as a global section. A global section executes analysis on
-    all of the files in its `files` attribute and reports diagnostic messages
-    on all the corresponding files open in the editor. If `cls_as_global` is
-    `false` then analysis runs only on the file currently being edited.
-    `cls_as_global` will default to false.
+   - `cls_fixes_enabled`: A boolean value indicating if the code fixes
+     generated by the section should be sent to the editor for being applied.
+     Initially only `formatting` request will respond with code fixes.
+
+   - `cls_as_global`: A boolean flag indicating if the section should be
+     considered as a global section. A global section executes analysis on
+     all of the files in its `files` attribute and reports diagnostic messages
+     on all the corresponding files open in the editor. If `cls_as_global` is
+     `false` then analysis runs only on the file currently being edited.
+     `cls_as_global` will default to false.
 
 2. Custom entry point into coala core
    Since coala core was not designed to be a long running process coalib

cEP-0028.md Outdated
of the coala language server, it will require an entry point that supports:

- Support for `FileProxies`: Since not all changes on the editor are flushed
to the disk coala core will have to support processing file content directly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -98,8 +98,8 @@
    of the coala language server, it will require an entry point that supports:
 
    - Support for `FileProxies`: Since not all changes on the editor are flushed
-   to the disk coala core will have to support processing file content directly
-   as opposed to files.
+     to the disk coala core will have to support processing file content directly
+     as opposed to files.
 
    - Support for preprocessing coala configurations: The configurations for
    coala analysis need to be generated at runtime for each analysis cycle based

cEP-0028.md Outdated
as opposed to files.

- Support for preprocessing coala configurations: The configurations for
coala analysis need to be generated at runtime for each analysis cycle based

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -102,8 +102,8 @@
    as opposed to files.
 
    - Support for preprocessing coala configurations: The configurations for
-   coala analysis need to be generated at runtime for each analysis cycle based
-   upon the `cls` parameters.
+     coala analysis need to be generated at runtime for each analysis cycle based
+     upon the `cls` parameters.
 
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point

cEP-0028.md Outdated

The following functions are core to the current general cli entry point and
need to be patched as part of the custom coala language server entry point
for:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -108,6 +108,7 @@
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point
    for: 
+
    - `coalib.processes.Processing.get_file_dict()` 
    - `coalib.processes.Processing.execute_section()`
    - `coalib.coala_main.run_coala()`

cEP-0028.md Outdated
- `coalib.coala_main.run_coala()`

The prototypes for functions that will replace/patch those are:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp0c390c0x/cEP-0028.md
+++ b/tmp/tmp0c390c0x/cEP-0028.md
@@ -113,7 +113,7 @@
    - `coalib.coala_main.run_coala()`
 
    The prototypes for functions that will replace/patch those are:
-   
+
    ```python
     def get_file_dict(filename_list,
                       fileproxy_map,

cEP-0028.md Outdated
cls_enabled = False
bears = SomeLongRunningBear
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -54,7 +54,7 @@
     cls_enabled = False
     bears = SomeLongRunningBear
    ```
-   
+
    This kind of a configuration will disable the bear completely for invocations
    of coala via a language server while enabling it for regular invocations.
 

cEP-0028.md Outdated

The following functions are core to the current general cli entry point and
need to be patched as part of the custom coala language server entry point
for:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -107,7 +107,7 @@
 
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point
-   for: 
+   for:
    - `coalib.processes.Processing.get_file_dict()` 
    - `coalib.processes.Processing.execute_section()`
    - `coalib.coala_main.run_coala()`

cEP-0028.md Outdated
The following functions are core to the current general cli entry point and
need to be patched as part of the custom coala language server entry point
for:
- `coalib.processes.Processing.get_file_dict()`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -108,7 +108,7 @@
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point
    for: 
-   - `coalib.processes.Processing.get_file_dict()` 
+   - `coalib.processes.Processing.get_file_dict()`
    - `coalib.processes.Processing.execute_section()`
    - `coalib.coala_main.run_coala()`
 

cEP-0028.md Outdated
- `coalib.coala_main.run_coala()`

The prototypes for functions that will replace/patch those are:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -113,7 +113,7 @@
    - `coalib.coala_main.run_coala()`
 
    The prototypes for functions that will replace/patch those are:
-   
+
    ```python
     def get_file_dict(filename_list,
                       fileproxy_map,

cEP-0028.md Outdated
@@ -0,0 +1,146 @@
# Optimizing coala for language server

| Metadata | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -1,13 +1,13 @@
 # Optimizing coala for language server
 
-| Metadata |                                            |
-| -------- | ------------------------------------------ |
-| cEP      | 0028                                       |
-| Version  | 0.1                                        |
-| Title    | Optimizing coala for language server       |
-| Authors  | Kilari Teja <mailto:ksdme9@gmail.com>      |
-| Status   | Proposed                                   |
-| Type     | Process                                    |
+| Metadata |                                       |
+| -------- | ------------------------------------- |
+| cEP      | 0028                                  |
+| Version  | 0.1                                   |
+| Title    | Optimizing coala for language server  |
+| Authors  | Kilari Teja <mailto:ksdme9@gmail.com> |
+| Status   | Proposed                              |
+| Type     | Process                               |
 
 ## Abstract
 

cEP-0028.md Outdated
cls_enabled = False
bears = SomeLongRunningBear
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -54,7 +54,7 @@
     cls_enabled = False
     bears = SomeLongRunningBear
    ```
-   
+
    This kind of a configuration will disable the bear completely for invocations
    of coala via a language server while enabling it for regular invocations.
 

cEP-0028.md Outdated

This example shows a configuration where the section is disabled for coala
but will only be enabled when the code editor dispatches a request of type
```textDocuemnt/didSave```.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -68,29 +68,31 @@
 
    This example shows a configuration where the section is disabled for coala
    but will only be enabled when the code editor dispatches a request of type
-   ```textDocuemnt/didSave```.
+   `textDocuemnt/didSave`.
 
    ### Supported Parameters
+
    The following are the supported parameter types:
-    - `cls_enabled`: A boolean indicating if the section should be enabled.
-    Disabling the section will turn if off for coala lang server. It will
-    default to true.
 
-    - `cls_on`: A list containing some or all of the available options,
-    `every`, `open`, `save`, `change`, `formatting`. This indicates the
-    type of request(s) the section should be executed on. `cls_on` will
-    default to `all`.
+   - `cls_enabled`: A boolean indicating if the section should be enabled.
+     Disabling the section will turn if off for coala lang server. It will
+     default to true.
 
-    - `cls_fixes_enabled`: A boolean value indicating if the code fixes
-    generated by the section should be sent to the editor for being applied.
-    Initially only `formatting` request will respond with code fixes.
+   - `cls_on`: A list containing some or all of the available options,
+     `every`, `open`, `save`, `change`, `formatting`. This indicates the
+     type of request(s) the section should be executed on. `cls_on` will
+     default to `all`.
 
-    - `cls_as_global`: A boolean flag indicating if the section should be
-    considered as a global section. A global section executes analysis on
-    all of the files in its `files` attribute and reports diagnostic messages
-    on all the corresponding files open in the editor. If `cls_as_global` is
-    `false` then analysis runs only on the file currently being edited.
-    `cls_as_global` will default to false.
+   - `cls_fixes_enabled`: A boolean value indicating if the code fixes
+     generated by the section should be sent to the editor for being applied.
+     Initially only `formatting` request will respond with code fixes.
+
+   - `cls_as_global`: A boolean flag indicating if the section should be
+     considered as a global section. A global section executes analysis on
+     all of the files in its `files` attribute and reports diagnostic messages
+     on all the corresponding files open in the editor. If `cls_as_global` is
+     `false` then analysis runs only on the file currently being edited.
+     `cls_as_global` will default to false.
 
 2. Custom entry point into coala core
    Since coala core was not designed to be a long running process coalib

cEP-0028.md Outdated
of the coala language server, it will require an entry point that supports:

- Support for `FileProxies`: Since not all changes on the editor are flushed
to the disk coala core will have to support processing file content directly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -98,8 +98,8 @@
    of the coala language server, it will require an entry point that supports:
 
    - Support for `FileProxies`: Since not all changes on the editor are flushed
-   to the disk coala core will have to support processing file content directly
-   as opposed to files.
+     to the disk coala core will have to support processing file content directly
+     as opposed to files.
 
    - Support for preprocessing coala configurations: The configurations for
    coala analysis need to be generated at runtime for each analysis cycle based

cEP-0028.md Outdated
as opposed to files.

- Support for preprocessing coala configurations: The configurations for
coala analysis need to be generated at runtime for each analysis cycle based

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -102,8 +102,8 @@
    as opposed to files.
 
    - Support for preprocessing coala configurations: The configurations for
-   coala analysis need to be generated at runtime for each analysis cycle based
-   upon the `cls` parameters.
+     coala analysis need to be generated at runtime for each analysis cycle based
+     upon the `cls` parameters.
 
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point

cEP-0028.md Outdated

The following functions are core to the current general cli entry point and
need to be patched as part of the custom coala language server entry point
for:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -108,6 +108,7 @@
    The following functions are core to the current general cli entry point and
    need to be patched as part of the custom coala language server entry point
    for: 
+
    - `coalib.processes.Processing.get_file_dict()` 
    - `coalib.processes.Processing.execute_section()`
    - `coalib.coala_main.run_coala()`

cEP-0028.md Outdated
- `coalib.coala_main.run_coala()`

The prototypes for functions that will replace/patch those are:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpv16bydy5/cEP-0028.md
+++ b/tmp/tmpv16bydy5/cEP-0028.md
@@ -113,7 +113,7 @@
    - `coalib.coala_main.run_coala()`
 
    The prototypes for functions that will replace/patch those are:
-   
+
    ```python
     def get_file_dict(filename_list,
                       fileproxy_map,

cEP-0028.md Outdated
of the coala language server, it will require an entry point that supports:

- Support for `FileProxies`: Since not all changes on the editor are flushed
to the disk coala core will have to support processing file content directly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line must be at most 80 characters maximum-line-length remark-lint

Origin: MarkdownBear, Section: markdown.

cEP-0028.md Outdated
as opposed to files.

- Support for preprocessing coala configurations: The configurations for
coala analysis need to be generated at runtime for each analysis cycle based

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line must be at most 80 characters maximum-line-length remark-lint

Origin: MarkdownBear, Section: markdown.

cEP-0028.md Outdated
Note that these are primarily caches with extended support
for additional features.

- FileDictFileCache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpnbc40gqf/cEP-0028.md
+++ b/tmp/tmpnbc40gqf/cEP-0028.md
@@ -373,7 +373,7 @@
     Note that these are primarily caches with extended support
     for additional features.
 
-      - FileDictFileCache
+    - FileDictFileCache
 
       ```python
       class FileDictFileCache(FileCache):

cEP-0028.md Outdated
allow_raw_files=allow_raw_files)
```

- ProxyMapFileCache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpnbc40gqf/cEP-0028.md
+++ b/tmp/tmpnbc40gqf/cEP-0028.md
@@ -396,7 +396,7 @@
                                allow_raw_files=allow_raw_files)
       ```
 
-      - ProxyMapFileCache
+    - ProxyMapFileCache
 
       ```python
       class ProxyMapFileCache(FileCache):

cEP-0028.md Outdated
filename_list, self.__proxymap, allow_raw_files)
```

- coalaLsFileCache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpnbc40gqf/cEP-0028.md
+++ b/tmp/tmpnbc40gqf/cEP-0028.md
@@ -418,36 +418,36 @@
                     filename_list, self.__proxymap, allow_raw_files)
       ```
 
-      - coalaLsFileCache
-
-        `coalals.utils.files.coalaLsFileCache` will be a direct subclass of
-        ProxyMapFileCache and is intended to stay as part of coala-ls.
-        Instances of coalaLsFileCache will be passed down to `run_coala()`,
-        this class will additionally support collection of information from
-        coala-core.
-
-        ```python
-        class coalaLsFileCache(ProxyMapFileCache):
-          """
-          Subclass of ProxyMapFileCache with support
-          for information logging.
-          """
-
-          def __init__(self, *args, **kargs):
-            super().__init__(*args, **kargs)
-            self._ls_logger = None
-
-          def ls_init(self, fileproxy_map=None, ls_logger=None):
-            if fileproxy_map is not None:
-              super().set_proxymap(fileproxy_map)
-
-            if ls_logger is not None:
-              self._ls_logger = ls_logger
-
-          def track_files(self, files):
-            self._ls_logger('Tracking files: '+str(files))
-            return super().track_files(files)
-        ```
+    - coalaLsFileCache
+
+      `coalals.utils.files.coalaLsFileCache` will be a direct subclass of
+      ProxyMapFileCache and is intended to stay as part of coala-ls.
+      Instances of coalaLsFileCache will be passed down to `run_coala()`,
+      this class will additionally support collection of information from
+      coala-core.
+
+      ```python
+      class coalaLsFileCache(ProxyMapFileCache):
+        """
+        Subclass of ProxyMapFileCache with support
+        for information logging.
+        """
+
+        def __init__(self, *args, **kargs):
+          super().__init__(*args, **kargs)
+          self._ls_logger = None
+
+        def ls_init(self, fileproxy_map=None, ls_logger=None):
+          if fileproxy_map is not None:
+            super().set_proxymap(fileproxy_map)
+
+          if ls_logger is not None:
+            self._ls_logger = ls_logger
+
+        def track_files(self, files):
+          self._ls_logger('Tracking files: '+str(files))
+          return super().track_files(files)
+      ```
 
   - `coalib.misc.Caching.ProxyMapFileCache.get_file_dict_from_fileproxy_map()`
 

@jayvdb
Copy link
Member

jayvdb commented Aug 13, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

This proposal describes techniques to optimize
coala language server.

Closes coala#156
@gitmate-bot
Copy link

Automated rebase with GitMate.io was successful! 🎉

@jayvdb jayvdb dismissed Makman2’s stale review August 13, 2018 03:21

code already merged

@jayvdb
Copy link
Member

jayvdb commented Aug 13, 2018

ack 07a63ec

@jayvdb
Copy link
Member

jayvdb commented Aug 13, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated fastforward failed! Please fastforward your pull request manually via the command line.

Reason:

Command: git push upstream HEAD:master

Exit Code: 128

Cause:

fatal: unable to access '<hidden_oauth_token>/': Could not resolve host: github.com


@jayvdb
Copy link
Member

jayvdb commented Aug 13, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot gitmate-bot merged commit 07a63ec into coala:master Aug 13, 2018
@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants