Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python manage.py distill-local returns exit status 0 on failure #21

Open
jayvdb opened this issue Dec 4, 2017 · 5 comments
Open

python manage.py distill-local returns exit status 0 on failure #21

jayvdb opened this issue Dec 4, 2017 · 5 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Dec 4, 2017

There have been a few failures to build, which havent been seen because python manage.py distill-local doesnt return a non-zero exit status.

#19 is one such occurrence, which was with Django 2.

Here is the same occurring when using Django <2.0

https://travis-ci.org/jayvdb/coala_community/builds/311125722#L1182

@jayvdb
Copy link
Member Author

jayvdb commented Dec 4, 2017

The exception is rippling all the way up to at least Django django.core.management, so this must be a bug in manage.py , or ... ?

@jayvdb
Copy link
Member Author

jayvdb commented Dec 4, 2017

django-distill kindly worked around this by catching and exiting.
It is still a bug upstream in Django IMO, but now a lower priority.

@andrewda
Copy link
Member

andrewda commented Dec 4, 2017

Actually, this might also be an issue with the .travis.yml. I moved it to the after_success build step in #14, but failures in that step do not cause the entire Travis build to fail. See docs.

Let's try moving python manage.py distill-local back to the script step, but keep the .ci/deploy.sh stuff in the after_success step.

@KVGarg
Copy link
Contributor

KVGarg commented Feb 12, 2019

How to re-produce this error ? Because currently there is no such build failure while we deploy new changes !!

@jayvdb
Copy link
Member Author

jayvdb commented Feb 13, 2019

Look at distill-local source code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants