-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md: Update header image #249
Conversation
0230a0b
to
2c481f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jayvdb
Hey @li-boxuan, can this be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this logo is still a bit coala-specific, as there are many logos related to angular, linux, etc. Another concern is whether these logos violate their copyright.
I am approving this PR as it LGTM for now; not confident to merge it though.
CC @jayvdb
This is true that I have added programming languages based on languages being used by coala community, but the devs outside circle in the image shows the all the developers having knowledge about all the programming language. If needed, we can have the logos of most common programming languages used today.
Used images have no copyright issue, downloaded from freepik.com and after downloading them I've modified them too, to make it completely different from the original ones. the were treated as base images on which the oepn-source community related ideas can be added! So, These images don't violate any kind of copyright. |
Deploy request for coala-community pending review. Review with commit 57f210a |
Travis tests have failedHey @KVGarg, 1st Buildpytest
TravisBuddy Request Identifier: 729730e0-bddb-11ea-a595-8f8781864445 |
9ee2d46
to
c635366
Compare
Travis tests have failedHey @KVGarg, 1st Buildpytest
TravisBuddy Request Identifier: 76e1b660-bddc-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildpytest
TravisBuddy Request Identifier: c65e1210-bddc-11ea-a595-8f8781864445 |
739b207
to
ec29db9
Compare
Hey @KVGarg, TravisCI finished with status TravisBuddy Request Identifier: 0bd7ba40-bde1-11ea-a595-8f8781864445 |
Hey @KVGarg, TravisCI finished with status TravisBuddy Request Identifier: 85ba8c90-bde4-11ea-a595-8f8781864445 |
ec29db9
to
f7a4f50
Compare
Travis tests have failedHey @KVGarg, 1st Buildpytest
TravisBuddy Request Identifier: afbb2760-bde5-11ea-a595-8f8781864445 |
a7f0655
to
7691e8e
Compare
The new header image is designed on the thought that this project is a re-usable project which can be forked by any other organisation. Therefore, the header should be a project specific logo which symbolises three components - creating, growing and supporting community. Closes coala#55
16c75ab
to
c2b3422
Compare
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: a7441bf0-bdf4-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildpytest
TravisBuddy Request Identifier: ba0469b0-bdf5-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: f60ccd20-bdf6-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -V
2nd Buildpytest
TravisBuddy Request Identifier: 493abf20-bdf7-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildcoala --flush-cache --non-interactive -V
TravisBuddy Request Identifier: 56721e80-bdf8-11ea-a595-8f8781864445 |
aea3368
to
57f210a
Compare
@@ -43,7 +50,7 @@ script: | |||
- ./.ci/build.sh | |||
- rm -rf private/ | |||
- pytest | |||
- coala --non-interactive -V | |||
- coala --flush-cache --non-interactive -V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess so, yes! Otherwise the build was failing unnecessarily if the files weren't changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if there are minor changes, like 2-3 lines of code still it was failing. That's why I added this up to re-run the coala on entire project irrespective of cache
0ac9693
to
bf13805
Compare
bf13805
to
2f88470
Compare
The new header image is designed on the thought
that this project is a re-usable project which
can be forked by any other organisation. Therefore,
the header should be a project specific logo which
symbolises three components - creating, growing and
supporting community.
Closes #55