README.md: Update header image #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KVGarg
force-pushed
the
header-image-update
branch
from
0230a0b
to
2c481f3
Compare
sks444
approved these changes
Jun 5, 2019
|
Hey @li-boxuan, can this be merged? |
li-boxuan
approved these changes
Aug 3, 2019
There was a problem hiding this comment.
IMO this logo is still a bit coala-specific, as there are many logos related to angular, linux, etc. Another concern is whether these logos violate their copyright.
I am approving this PR as it LGTM for now; not confident to merge it though.
CC @jayvdb
This is true that I have added programming languages based on languages being used by coala community, but the devs outside circle in the image shows the all the developers having knowledge about all the programming language. If needed, we can have the logos of most common programming languages used today.
Used images have no copyright issue, downloaded from freepik.com and after downloading them I've modified them too, to make it completely different from the original ones. the were treated as base images on which the oepn-source community related ideas can be added! So, These images don't violate any kind of copyright. |
|
Deploy request for coala-community pending review. Review with commit 57f210a |
Travis tests have failedHey @KVGarg, 1st BuildpytestTravisBuddy Request Identifier: 729730e0-bddb-11ea-a595-8f8781864445 |
KVGarg
force-pushed
the
header-image-update
branch
from
9ee2d46
to
c635366
Compare
Travis tests have failedHey @KVGarg, 1st BuildpytestTravisBuddy Request Identifier: 76e1b660-bddc-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st BuildpytestTravisBuddy Request Identifier: c65e1210-bddc-11ea-a595-8f8781864445 |
KVGarg
force-pushed
the
header-image-update
branch
4 times, most recently
from
739b207
to
ec29db9
Compare
|
Hey @KVGarg, TravisCI finished with status TravisBuddy Request Identifier: 0bd7ba40-bde1-11ea-a595-8f8781864445 |
|
Hey @KVGarg, TravisCI finished with status TravisBuddy Request Identifier: 85ba8c90-bde4-11ea-a595-8f8781864445 |
KVGarg
force-pushed
the
header-image-update
branch
from
ec29db9
to
f7a4f50
Compare
Travis tests have failedHey @KVGarg, 1st BuildpytestTravisBuddy Request Identifier: afbb2760-bde5-11ea-a595-8f8781864445 |
KVGarg
force-pushed
the
header-image-update
branch
2 times, most recently
from
a7f0655
to
7691e8e
Compare
The new header image is designed on the thought that this project is a re-usable project which can be forked by any other organisation. Therefore, the header should be a project specific logo which symbolises three components - creating, growing and supporting community. Closes coala#55
KVGarg
force-pushed
the
header-image-update
branch
2 times, most recently
from
16c75ab
to
c2b3422
Compare
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: a7441bf0-bdf4-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st BuildpytestTravisBuddy Request Identifier: ba0469b0-bdf5-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: f60ccd20-bdf6-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -V2nd BuildpytestTravisBuddy Request Identifier: 493abf20-bdf7-11ea-a595-8f8781864445 |
Travis tests have failedHey @KVGarg, 1st Buildcoala --flush-cache --non-interactive -VTravisBuddy Request Identifier: 56721e80-bdf8-11ea-a595-8f8781864445 |
KVGarg
force-pushed
the
header-image-update
branch
from
aea3368
to
57f210a
Compare
abhishalya
reviewed
Jul 4, 2020
| @@ -43,7 +50,7 @@ script: | |||
| - ./.ci/build.sh | |||
| - rm -rf private/ | |||
| - pytest | |||
| - coala --non-interactive -V | |||
| - coala --flush-cache --non-interactive -V | |||
There was a problem hiding this comment.
I guess so, yes! Otherwise the build was failing unnecessarily if the files weren't changed
There was a problem hiding this comment.
Even if there are minor changes, like 2-3 lines of code still it was failing. That's why I added this up to re-run the coala on entire project irrespective of cache
KVGarg
force-pushed
the
header-image-update
branch
from
0ac9693
to
bf13805
Compare
KVGarg
force-pushed
the
header-image-update
branch
from
bf13805
to
2f88470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new header image is designed on the thought
that this project is a re-usable project which
can be forked by any other organisation. Therefore,
the header should be a project specific logo which
symbolises three components - creating, growing and
supporting community.
Closes #55