Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Update header image #249

Merged
merged 2 commits into from
Jul 5, 2020
Merged

README.md: Update header image #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
857132f
README.md: Update header image
KVGarg May 28, 2019
2f88470
travis.yml: Fix the stages
KVGarg Jul 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,22 @@
language: python
python: 3.6.3

cache:
pip: true
cache: false

stages:
- test
- moban
- name: deploy
if: type != pull_request

.moban: &moban
python: 3.6
stage: moban
install: pip install moban~=0.5.0 gitfs2 pypifs
script:
- moban
- git diff --exit-code

env:
global:
- ENCRYPTION_LABEL: "defac9b1fa56"
Expand All @@ -25,13 +32,9 @@ jobs:
# A proper build with the tokens available
- stage: deploy
after_success: ./.ci/deploy.sh
- python: 3.6
stage: moban
env:
before_install: false
install: pip install moban
script: .ci/check_moban.sh
after_success: false
- *moban
allow_failures:
- *moban

before_install:
- printf '%s\n'
Expand All @@ -43,7 +46,7 @@ script:
- ./.ci/build.sh
- rm -rf private/
- pytest
- coala --non-interactive -V
- coala --flush-cache --non-interactive -V
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so, yes! Otherwise the build was failing unnecessarily if the files weren't changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if there are minor changes, like 2-3 lines of code still it was failing. That's why I added this up to re-run the coala on entire project irrespective of cache


notifications:
email: false
Expand Down
Binary file modified docs/_static/images/header.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ addopts =
--color=yes
--doctest-glob=*.rst
--doctest-modules
--doctest-ignore-import-error
--doctest-ignore-import-errors
--error-for-skips
--cov
--instafail
Expand Down
2 changes: 1 addition & 1 deletion test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ codecov~=2.0.5
moban~=0.5.0 ; python_version > '3.0'
packaging~=16.8
pytest~=3.6.4
pytest-cov~=2.4
pytest-cov==2.4
pytest-django~=3.3.3
pytest-env~=0.6.0
pytest-error-for-skips~=1.0
Expand Down