Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as #595

Closed
wants to merge 1 commit into from
Closed

as #595

wants to merge 1 commit into from

Conversation

vaibhav9619
Copy link

@vaibhav9619 vaibhav9619 commented Aug 1, 2018

Closes #579

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

@TravisBuddy
Copy link

Travis tests have failed

Hey @vaibhav9619,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

python -m pytest
============================= test session starts ==============================
platform linux -- Python 3.6.3, pytest-3.6.4, py-1.5.2, pluggy-0.6.0
rootdir: /home/travis/build/coala/corobo, inifile: setup.cfg
plugins: requests-mock-1.5.2, xdist-1.22.5, travis-fold-1.3.0, timeout-1.3.1, reqs-0.0.7, reorder-0.1.1, profiling-1.3.0, mock-1.10.0, instafail-0.3.0, forked-0.2, error-for-skips-1.0.0, env-0.6.2, cov-2.5.1
collected 39 items                                                             

tests/answer_test.py .                                                   [  2%]
tests/ban_test.py ..                                                     [  7%]
tests/coala_lowercase_c_test.py ..                                       [ 12%]
tests/coatils_test.py ...........                                        [ 41%]
tests/deprecate_bot_prefixes_test.py .                                   [ 43%]
tests/explain_test.py .                                                  [ 46%]
tests/ghetto_test.py .                                                   [ 48%]
tests/git_stats_test.py .                                                [ 51%]
tests/labhub_test.py .........                                           [ 74%]
tests/lmgtfy_test.py .                                                   [ 76%]
tests/nevermind_test.py .                                                [ 79%]
tests/pitchfork_test.py .                                                [ 82%]
tests/ship_it_test.py .                                                  [ 84%]
tests/spam_test.py ....                                                  [ 94%]
tests/the_rules_test.py .                                                [ 97%]
tests/wolfram_alpha_test.py .                                            [100%]

travis_fold:start:py-5599.cov.0
----------- coverage: platform linux, python 3.6.3-final-0 -----------
Name                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------
plugins/__init__.py                     0      0   100%
plugins/answer.py                      25      0   100%
plugins/ban.py                         37      0   100%
plugins/coala_lowercase_c.py           12      0   100%
plugins/coatils.py                    118      0   100%
plugins/constants.py                    7      0   100%
plugins/deprecate_bot_prefixes.py       6      0   100%
plugins/explain.py                     20      0   100%
plugins/ghetto.py                      10      0   100%
plugins/git_stats.py                   51      0   100%
plugins/labhub.py                     236      0   100%
plugins/lmgtfy.py                       4      0   100%
plugins/nevermind.py                    5      0   100%
plugins/pitchfork.py                   12      0   100%
plugins/searchdocs.py                  16      9    44%   23-34
plugins/searchdocs_test.py              6      6     0%   1-13
plugins/ship_it.py                      7      0   100%
plugins/spam.py                        13      0   100%
plugins/the_rules.py                    5      0   100%
plugins/wolfram_alpha.py               18      0   100%
-----------------------------------------------------------------
TOTAL                                 608     15    98%
travis_fold:end:py-5599.cov.0

FAIL Required test coverage of 100% not reached. Total coverage: 97.53%

=============================== warnings summary ===============================
<undetermined location>
  Module already imported so cannot be rewritten: errbot.backends.test

tests/labhub_test.py::TestBot
  cannot collect test class 'TestBot' because it has a __init__ constructor

tests/spam_test.py::TestBot
  cannot collect test class 'TestBot' because it has a __init__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
=================== 39 passed, 3 warnings in 128.25 seconds ====================

@jayvdb
Copy link
Member

jayvdb commented Aug 1, 2018

Please read #579 (comment)

@jayvdb
Copy link
Member

jayvdb commented Aug 13, 2018

Created duplicate PRs that are broken.

@jayvdb jayvdb closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants