nevermind.py: Add caret in regex pattern #605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add caret in regex pattern so that 'corobo nm' and 'corobo nevermind'
are matched only, and only then corobo says "I'm sorry :(".
Thus, corobo would not respond with a sorry for commands where nm
or nevermind appear anywhere in the command.
Fixes coala#519
nvzard
suggested changes
Aug 5, 2018
|
@jayvdb what does "!" In the beginning of "nevermind" mean in the test file? |
|
That is 'BOT_PREFIX' , just like we use 'corobo' as our bot's prefix. Go
through the documentation and you'll understand.
…On Mon 6 Aug, 2018, 11:15 AM Bhavya Srivastava, ***@***.***> wrote:
@jayvdb <https://github.com/jayvdb> what does "!" In the beginning of
"nevermind" mean in the test file?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#605 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ASansMihYVRaJcVouVKzrF6yhTWiFAxQks5uN9f4gaJpZM4Vvf3r>
.
|
Add '$' in regex pattern so that corobo only responds "I'm sorry :("
if it encounters "corobo nm" or "corobo nevermind", and does not
respond with a sorry if there is anything after nm or nevermind.
Also add unit test case for the change made.
Fixes coala#519
Travis tests have failedHey @bhavya17037, 1st Buildcoala --non-interactive -Vpython -m pytest |
|
Sorry @TravisBuddy, you do not have the necessary permission levels to perform the action. |
Add $ sign in regex pattern so that anything after "nm" or "nevermind" is not matched. Fixes coala#519
Travis tests have failedHey @bhavya17037, 1st Buildcoala --non-interactive -V |
Vamshi99
reviewed
Aug 6, 2018
| @@ -8,7 +8,7 @@ class Nevermind(BotPlugin): | |||
| Doesn't mind | |||
| """ | |||
|
|
|||
| @re_botcmd(pattern=r'(nm)|(nevermind)', flags=re.IGNORECASE) | |||
| @re_botcmd(pattern=r'^(nm)$|^(nevermind)$', flags=re.IGNORECASE) | |||
There was a problem hiding this comment.
A better way r'^(?:nm|nevermind)$'
|
@bhavya17037 You have multiple commits, squash all your commits into a single one, refer http://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits, don't close this PR. Also, fix errors reported by coala. |
@bhavya17037 Please read what I have said 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add caret in regex pattern so that 'corobo nm' and 'corobo nevermind'
are matched only, and only then corobo says "I'm sorry :(".
Thus, corobo would not respond with a sorry for commands where nm
or nevermind appear anywhere in the command.
Fixes #519
Reviewers Checklist
botcmdandre_botcmddecorators.