Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nevermind plugin regex #519

Closed
Vamshi99 opened this issue Apr 2, 2018 · 3 comments
Closed

Change nevermind plugin regex #519

Vamshi99 opened this issue Apr 2, 2018 · 3 comments
Assignees
@bhavya17037
Labels
bug difficulty/low

Comments

@Vamshi99
Copy link
Member

Vamshi99 commented Apr 2, 2018

Currently corobo says sorry, whenever there is nm or nevermind in a sentence(when corobo is first word), so make it a full match. It should only respond when we say corobo nm or corobo nevermind.
label: type/regex difficulty/newcomer
@gitmate-bot
Copy link

GitMate.io thinks possibly related issues are #4 (Nevermind), #38 (Vote plugin), #348 (Create SO question plugin), #73 (Add doc string to the command in nevermind plugin), and #223 (Available username plugin).

@usmanmuhd
Copy link

I would like to work on this issue.
Can anyone assign me?

@Makman2 Makman2 added the bug label Apr 2, 2018
@bhavya17037
Copy link
Contributor

I want to work on this issue. Can I be assigned to this?

bhavya17037 added a commit to bhavya17037/corobo that referenced this issue Aug 5, 2018
@bhavya17037
nevermind.py: Add caret in regex pattern
244080c 
Add caret in regex pattern so that 'corobo nm' and 'corobo nevermind'
are matched only, and only then corobo says "I'm sorry :(".
Thus, corobo would not respond with a sorry for commands where nm
or nevermind appear anywhere in the command.

Fixes coala#519
@bhavya17037 bhavya17037 mentioned this issue Aug 5, 2018
Closed
6 tasks
bhavya17037 added a commit to bhavya17037/corobo that referenced this issue Aug 6, 2018
@bhavya17037
nevermind.py: Add '$' in regex pattern
bd8b472 
Add '$' in regex pattern so that corobo only responds "I'm sorry :("
if it encounters "corobo nm" or "corobo nevermind", and does not
respond with a sorry if there is anything after nm or nevermind.
Also add unit test case for the change made.

Fixes coala#519
bhavya17037 added a commit to bhavya17037/corobo that referenced this issue Aug 6, 2018
@bhavya17037
nevermind.py: Add $ sign in regex pattern
4ed8339 
Add $ sign in regex pattern so that anything after "nm" or
"nevermind" is not matched.

Fixes coala#519
bhavya17037 added a commit to bhavya17037/corobo that referenced this issue Aug 6, 2018
@bhavya17037
nevermind.py: Change regex pattern
7b77738 
Change regex pattern so that corobo does not apologise when
commands like "corobo nm" and "corobo nevermind" are used

Fixes coala#519
@bhavya17037 bhavya17037 mentioned this issue Aug 6, 2018
Merged
6 tasks
bhavya17037 added a commit to bhavya17037/corobo that referenced this issue Aug 6, 2018
@bhavya17037
nevermind.py: Change regex pattern
f6149f3 
Change regex pattern so that corobo does not apologise when
commands like "corobo nm" and "corobo nevermind" are used

Fixes coala#519
bhavya17037 added a commit to bhavya17037/corobo that referenced this issue Aug 7, 2018
@bhavya17037
nevermind.py: Change regex pattern
a273a10 
Change regex pattern so that corobo apologizes only to commands
like "corobo nm" and "corobo nevermind". Add unit test cases
for the same.

Fixes coala#519
bhavya17037 added a commit to bhavya17037/corobo that referenced this issue Aug 7, 2018
@bhavya17037
nevermind.py: Change regex pattern
6608678 
Change regex pattern so that corobo apologizes only to commands
like "corobo nm" and "corobo nevermind". Add unit test cases
for the same.

Fixes coala#519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhavya17037 bhavya17037

Labels
bug difficulty/low
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Makman2 @gitmate-bot @Vamshi99 @usmanmuhd @bhavya17037