nevermind.py: Change regex pattern #606
Conversation
There was a problem hiding this comment.
You have two commits at https://github.com/coala/corobo/pull/606/commits
We dont allow merges in our repos. Ever. Dont do it.
Rebase.
|
@jayvdb |
plugins/coatils.py
Outdated
| @@ -15,9 +15,6 @@ class Coatils(BotPlugin): | |||
| Various coala related utilities, exposing the REST API, etc. | |||
| """ | |||
|
|
|||
| def __init__(self, bot, name=None): | |||
There was a problem hiding this comment.
Remove this change from the file and do git commit --amend to modify the commit(do not use git commit)
There was a problem hiding this comment.
But this change is already in corobo's "coatils.py" (master)
There was a problem hiding this comment.
You need to fetch that change from upstream repo(master) by performing a rebase, refer http://api.coala.io/en/latest/Developers/Git_Basics.html#rebasing
gitmate-bot
added
process/pending review
process/approved
and removed
process/wip
process/pending review
labels
tests/nevermind_test.py
Outdated
| testbot.assertCommand("!hey nM", 'Command "hey" / "hey nM" not found.') | ||
| testbot.assertCommand("!nevermindxyz", 'Command "nevermindxyz" not found.') | ||
| testbot.assertCommand( | ||
| "!hey nEverMINd", 'Command "hey" / "hey nEverMINd" not found.') |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp2chs3k8n/tests/nevermind_test.py
+++ b/tmp/tmp2chs3k8n/tests/nevermind_test.py
@@ -12,4 +12,4 @@
testbot.assertCommand("!hey nM", 'Command "hey" / "hey nM" not found.')
testbot.assertCommand("!nevermindxyz", 'Command "nevermindxyz" not found.')
testbot.assertCommand(
- "!hey nEverMINd", 'Command "hey" / "hey nEverMINd" not found.')
+ "!hey nEverMINd", 'Command "hey" / "hey nEverMINd" not found.')
tests/nevermind_test.py
Outdated
| testbot.assertCommand("!hey nM", 'Command "hey" / "hey nM" not found.') | ||
| testbot.assertCommand("!nevermindxyz", 'Command "nevermindxyz" not found.') | ||
| testbot.assertCommand( | ||
| "!hey nEverMINd", 'Command "hey" / "hey nEverMINd" not found.') |
There was a problem hiding this comment.
E122 continuation line missing indentation or outdented
Origin: PycodestyleBear (E122), Section: all.autopep8.
Change regex pattern so that corobo apologizes only to commands like "corobo nm" and "corobo nevermind". Add unit test cases for the same. Fixes coala#519
This comment has been minimized.
This comment has been minimized.
|
ack 6608678 |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Change regex pattern so that corobo only apologizes
when "corobo nm" or "corobo nevermind" are used.
Also add unit tests for the same
Fixes #519
Reviewers Checklist
botcmdandre_botcmddecorators.