plugins:Add plugin for saying no to 'sir' #651

AkshJain99 · 2019-03-09T23:12:21Z

Reviewers Checklist

Appropriate logging is done.
Appropriate error responses.
Handle every possible exception.
Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
See that 100% coverage is there.
See to it that mocking is not done where it is not necessary.

gitmate-bot · 2019-03-09T23:15:58Z

plugins/no_sir.py

+        msg.frm,
+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa6hrtctc/plugins/no_sir.py +++ b/tmp/tmpa6hrtctc/plugins/no_sir.py @@ -14,5 +14,5 @@ msg.frm, '@{}, Do not use sir in your conversation. {}'.format( msg.frm.nick, emots[0] - ) + ) )```

Kindly use VSCode or any other editor to avoid such warnings.

I use VS code only

gitmate-bot · 2019-03-09T23:15:59Z

plugins/no_sir.py

+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)
+			)


Line contains following spacing inconsistencies:

No newline at EOF.

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa6hrtctc/plugins/no_sir.py +++ b/tmp/tmpa6hrtctc/plugins/no_sir.py @@ -15,4 +15,4 @@ '@{}, Do not use sir in your conversation. {}'.format( msg.frm.nick, emots[0] ) - )+ )

gitmate-bot · 2019-03-09T23:16:00Z

tests/no_sir_test.py

+
+    def test_no_sir(self, testbot):
+        testbot.push_message('sir')
+        assert 'Do not use sir in your conversation' in testbot.pop_message()


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa6hrtctc/tests/no_sir_test.py +++ b/tmp/tmpa6hrtctc/tests/no_sir_test.py @@ -8,4 +8,4 @@ def test_no_sir(self, testbot): testbot.push_message('sir') - assert 'Do not use sir in your conversation' in testbot.pop_message()+ assert 'Do not use sir in your conversation' in testbot.pop_message()

gitmate-bot · 2019-03-09T23:16:01Z

plugins/no_sir.py

@@ -0,0 +1,18 @@
+import re
+
+from errbot import BotPlugin, re_botcmd


This file contains unused source code.

Origin: PyUnusedCodeBear, Section: all.python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa6hrtctc/plugins/no_sir.py +++ b/tmp/tmpa6hrtctc/plugins/no_sir.py @@ -1,6 +1,7 @@ import re -from errbot import BotPlugin, re_botcmd +from errbot import BotPlugin +from errbot import re_botcmd class no_sir(BotPlugin):

gitmate-bot · 2019-03-09T23:16:01Z

tests/no_sir_test.py

@@ -0,0 +1,11 @@
+import os


This file contains unused source code.

Origin: PyUnusedCodeBear, Section: all.python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa6hrtctc/tests/no_sir_test.py +++ b/tmp/tmpa6hrtctc/tests/no_sir_test.py @@ -1,4 +1,3 @@ -import os import no_sir from errbot.backends.test import testbot

gitmate-bot · 2019-03-09T23:16:02Z

plugins/no_sir.py

+
+
+class no_sir(BotPlugin):
+  """


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa6hrtctc/plugins/no_sir.py +++ b/tmp/tmpa6hrtctc/plugins/no_sir.py @@ -4,15 +4,16 @@ class no_sir(BotPlugin): - """ - Do not use sir - """ - def callback_message(self, msg): - emots = [':D'] - if match_sir: - self.send( - msg.frm, - '@{}, Do not use sir in your conversation. {}'.format( - msg.frm.nick, emots[0] - ) - )+ """ + Do not use sir + """ + + def callback_message(self, msg): + emots = [':D'] + if match_sir: + self.send( + msg.frm, + '@{}, Do not use sir in your conversation. {}'.format( + msg.frm.nick, emots[0] + ) + )

gitmate-bot · 2019-03-09T23:16:03Z

plugins/no_sir.py

+
+
+class no_sir(BotPlugin):
+  """


E111 indentation is not a multiple of four

Origin: PycodestyleBear (E111), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:16:04Z

plugins/no_sir.py

+  """
+  Do not use sir
+  """
+  def callback_message(self, msg):


E111 indentation is not a multiple of four

Origin: PycodestyleBear (E111), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:16:05Z

plugins/no_sir.py

+  def callback_message(self, msg):
+    emots = [':D']
+    if match_sir:
+      self.send(


E111 indentation is not a multiple of four

Origin: PycodestyleBear (E111), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:16:06Z

plugins/no_sir.py

+        msg.frm,
+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)


E101 indentation contains mixed spaces and tabs

Origin: PycodestyleBear (E101), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:16:07Z

plugins/no_sir.py

+        msg.frm,
+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)


W191 indentation contains tabs

Origin: PycodestyleBear (W191), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:16:09Z

plugins/no_sir.py

+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)
+			)


W191 indentation contains tabs

Origin: PycodestyleBear (W191), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:16:09Z

plugins/no_sir.py

+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)
+			)


W292 no newline at end of file

Origin: PycodestyleBear (W292), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:16:10Z

tests/no_sir_test.py

+
+    def test_no_sir(self, testbot):
+        testbot.push_message('sir')
+        assert 'Do not use sir in your conversation' in testbot.pop_message()


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpa6hrtctc/tests/no_sir_test.py +++ b/tmp/tmpa6hrtctc/tests/no_sir_test.py @@ -8,4 +8,4 @@ def test_no_sir(self, testbot): testbot.push_message('sir') - assert 'Do not use sir in your conversation' in testbot.pop_message()+ assert 'Do not use sir in your conversation' in testbot.pop_message()

gitmate-bot · 2019-03-09T23:16:11Z

tests/no_sir_test.py

+
+    def test_no_sir(self, testbot):
+        testbot.push_message('sir')
+        assert 'Do not use sir in your conversation' in testbot.pop_message()


W292 no newline at end of file

Origin: PycodestyleBear (W292), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:19:39Z

plugins/no_sir.py

+        msg.frm,
+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpbr1ao5rr/plugins/no_sir.py +++ b/tmp/tmpbr1ao5rr/plugins/no_sir.py @@ -14,5 +14,5 @@ msg.frm, '@{}, Do not use sir in your conversation. {}'.format( msg.frm.nick, emots[0] - ) + ) )

gitmate-bot · 2019-03-09T23:19:39Z

plugins/no_sir.py

+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)
+			)


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpbr1ao5rr/plugins/no_sir.py +++ b/tmp/tmpbr1ao5rr/plugins/no_sir.py @@ -15,4 +15,4 @@ '@{}, Do not use sir in your conversation. {}'.format( msg.frm.nick, emots[0] ) - ) + )

gitmate-bot · 2019-03-09T23:19:41Z

plugins/no_sir.py

@@ -0,0 +1,18 @@
+import re
+
+from errbot import BotPlugin, re_botcmd


This file contains unused source code.

Origin: PyUnusedCodeBear, Section: all.python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpbr1ao5rr/plugins/no_sir.py +++ b/tmp/tmpbr1ao5rr/plugins/no_sir.py @@ -1,6 +1,7 @@ import re -from errbot import BotPlugin, re_botcmd +from errbot import BotPlugin +from errbot import re_botcmd class no_sir(BotPlugin):

gitmate-bot · 2019-03-09T23:19:42Z

tests/no_sir_test.py

@@ -0,0 +1,11 @@
+import os


This file contains unused source code.

Origin: PyUnusedCodeBear, Section: all.python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpbr1ao5rr/tests/no_sir_test.py +++ b/tmp/tmpbr1ao5rr/tests/no_sir_test.py @@ -1,4 +1,3 @@ -import os import no_sir from errbot.backends.test import testbot

gitmate-bot · 2019-03-09T23:19:43Z

plugins/no_sir.py

+
+
+class no_sir(BotPlugin):
+  """


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpbr1ao5rr/plugins/no_sir.py +++ b/tmp/tmpbr1ao5rr/plugins/no_sir.py @@ -4,15 +4,16 @@ class no_sir(BotPlugin): - """ - Do not use sir - """ - def callback_message(self, msg): - emots = [':D'] - if match_sir: - self.send( - msg.frm, - '@{}, Do not use sir in your conversation. {}'.format( - msg.frm.nick, emots[0] - ) - ) + """ + Do not use sir + """ + + def callback_message(self, msg): + emots = [':D'] + if match_sir: + self.send( + msg.frm, + '@{}, Do not use sir in your conversation. {}'.format( + msg.frm.nick, emots[0] + ) + )

gitmate-bot · 2019-03-09T23:19:44Z

plugins/no_sir.py

+
+
+class no_sir(BotPlugin):
+  """


E111 indentation is not a multiple of four

Origin: PycodestyleBear (E111), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:19:45Z

plugins/no_sir.py

+  """
+  Do not use sir
+  """
+  def callback_message(self, msg):


E111 indentation is not a multiple of four

Origin: PycodestyleBear (E111), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:19:45Z

plugins/no_sir.py

+  def callback_message(self, msg):
+    emots = [':D']
+    if match_sir:
+      self.send(


E111 indentation is not a multiple of four

Origin: PycodestyleBear (E111), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:19:47Z

plugins/no_sir.py

+        msg.frm,
+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)


E101 indentation contains mixed spaces and tabs

Origin: PycodestyleBear (E101), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:19:47Z

plugins/no_sir.py

+        msg.frm,
+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)


W191 indentation contains tabs

Origin: PycodestyleBear (W191), Section: all.autopep8.

gitmate-bot · 2019-03-09T23:19:48Z

plugins/no_sir.py

+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)
+			)


W191 indentation contains tabs

Origin: PycodestyleBear (W191), Section: all.autopep8.

sladyn98

Kindly run coala before you submit the changes :)

sladyn98 · 2019-03-10T03:18:20Z

plugins/no_sir.py

+  """
+  def callback_message(self, msg):
+    emots = [':D']
+    if match_sir:


@AkshJain99 What are you trying to do here? You instead should use a regex expression because the word sir could be present anywhere in the message.

sladyn98 · 2019-03-10T03:18:49Z

plugins/no_sir.py

+        msg.frm,
+        '@{}, Do not use sir in your conversation. {}'.format(
+          msg.frm.nick, emots[0]
+				)


Kindly use VSCode or any other editor to avoid such warnings.

sladyn98 · 2019-03-10T03:20:19Z

tests/no_sir_test.py

+    extra_plugin_dir = '.'
+
+    def test_no_sir(self, testbot):
+        testbot.push_message('sir')


Please read the above comment,this is just covering one of the scenarios.

sladyn98 · 2019-03-10T03:22:53Z

tests/no_sir_test.py

+
+    def test_no_sir(self, testbot):
+        testbot.push_message('sir')
+        assert 'Do not use sir in your conversation' in testbot.pop_message()


The assert statement does not match the bot output message, the test would always throw an assertion error because of the missing emot at the end

@sladyn98 it's in

@meetmangukiya Yeah your right,so it would pass, but it would be better to keep the outputs same although it doesnt matter :)

we have added a plugin and related test to prevent any contributor from saying sir. Closes coala#337

KVGarg · 2019-04-23T17:17:02Z

plugins/no_sir.py

+        if match_sir:
+            self.send(
+              msg.frm,
+              '@{}, Do not use sir in your conversation. {}'.format(


Please remove comma after mentioning the user!
Although the returned message is OK, I guess it could be more informative.
What do you think @sladyn98?

@KVGarg Definitely if you have any suggestions you could have written here :)

I guess we can frame a message somewhat like this

Hi @<username> :wave:! We don't use "Sir" in the community during the conversation. It's perfectly fine to call them via there usernames or handle. Also, If you want to do such think you can better go with buddy or something else :smiley:

Something like this the message can be framed!

KVGarg

Please re-base your branch!

AkshJain99 · 2019-04-23T17:19:36Z

Okay ,sure I will do that in bit

…

On Tue, 23 Apr 2019, 10:47 pm Keshav Garg, ***@***.***> wrote: ***@***.**** requested changes on this pull request. Please re-base your branch! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#651 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHCL3B5FX3TOY5CRYOEGRMTPR5ADPANCNFSM4G432YBA> .

AkshJain99 · 2019-04-23T17:39:27Z

@KVGarg sure I will look after ur suggestions , actually I m quite busy for a day or two soon I will look towards this pr Thanks

…

On Tue, 23 Apr 2019, 11:06 pm Keshav Garg, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In plugins/no_sir.py <#651 (comment)>: > +import re +from errbot import BotPlugin + + +class no_sir(BotPlugin): + """ + Do not use sir + """ + + def callback_message(self, msg): + emots = [':D'] + match_sir = re.search(r'\bsir\b', '\bSir\b', msg.body) + if match_sir: + self.send( + msg.frm, + '@{}, Do not use sir in your conversation. {}'.format( I guess we can frame a message somewhat like this Hi @<username> 👋! We don't use "Sir" in the community during the conversation. It's perfectly fine to call them via there usernames or handle. Also, If you to do such think you can better go with buddy 😃 Something like this the message can be framed! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#651 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHCL3B3LYBUB2IGAHLASYCLPR5CKDANCNFSM4G432YBA> .

meetmangukiya · 2019-04-25T05:43:27Z

tests/no_sir_test.py

+
+    def test_no_sir(self, testbot):
+        testbot.push_message('sir')
+        assert 'Do not use sir in your conversation' in testbot.pop_message()


@sladyn98 it's in

meetmangukiya · 2019-04-25T05:44:37Z

plugins/no_sir.py

+from errbot import BotPlugin
+
+
+class no_sir(BotPlugin):


class name not starting with caps 😱

Thats by mistake @meetmangukiya i will correct all the issues now in this pr

gitmate-bot added process/pending review size/XS difficulty/low importance/low initiatives/gci plugin proposal labels Mar 9, 2019

gitmate-bot assigned AkshJain99 Mar 9, 2019

AkshJain99 force-pushed the sir branch from 7efbf8e to fce4571 Compare March 9, 2019 23:14

gitmate-bot reviewed Mar 9, 2019

View reviewed changes

AkshJain99 force-pushed the sir branch from fce4571 to 7a7de3d Compare March 9, 2019 23:17

gitmate-bot reviewed Mar 9, 2019

View reviewed changes

sladyn98 suggested changes Mar 10, 2019

View reviewed changes

AkshJain99 force-pushed the sir branch 4 times, most recently from bbedddb to 735270b Compare March 10, 2019 10:11

Plugins: Add plugin for saying no to 'sir'.

44f2db5

we have added a plugin and related test to prevent any contributor from saying sir. Closes coala#337

AkshJain99 force-pushed the sir branch from 735270b to 44f2db5 Compare March 10, 2019 10:47

KVGarg reviewed Apr 23, 2019

View reviewed changes

KVGarg suggested changes Apr 23, 2019

View reviewed changes

meetmangukiya reviewed Apr 25, 2019

View reviewed changes

		@@ -0,0 +1,18 @@
		import re

		from errbot import BotPlugin, re_botcmd

plugins:Add plugin for saying no to 'sir' #651

Are you sure you want to change the base?

plugins:Add plugin for saying no to 'sir' #651

Conversation

AkshJain99 commented Mar 9, 2019 • edited Loading

Reviewers Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sladyn98 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KVGarg Apr 23, 2019 • edited Loading

Choose a reason for hiding this comment

KVGarg left a comment

Choose a reason for hiding this comment

AkshJain99 commented Apr 23, 2019 via email

AkshJain99 commented Apr 23, 2019 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkshJain99 commented Mar 9, 2019 •

edited

Loading

KVGarg Apr 23, 2019 •

edited

Loading