Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Use packaged pg_query gem #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yukiisbored
Copy link
Member

Fixes #117

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small concern: At the moment https://build.opensuse.org/package/show/home:yuki_is_bored/rubygem-pg_query is red for Tumbleweed.

However it is in http://download.opensuse.org/repositories/home:/yuki_is_bored/openSUSE_Tumbleweed/x86_64/ , so it must have built correctly previously.

How I think we structure this is I put my own created packages in
https://build.opensuse.org/project/show/home:jayvdb:my_coala

Do testing of any new package in
https://build.opensuse.org/project/show/home:jayvdb:test

And then placing everyones good packages in a 'release' area
https://build.opensuse.org/project/show/home:jayvdb:coala

So then home:jayvdb:coala only ever contains forks from elsewhere, and thus will be stable and tested together before being used on the docker, and our docker doesnt break because someone buggered up their build home.

Anyway, after #146 , the fact that your Tumbleweed doesnt build wont be a problem ;-)

@@ -92,6 +92,7 @@ RUN \
ruby \
ruby-devel \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant this be removed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants