re-implement lexicals using GLOBAL-VARS
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft PR until it is benchmarked. |
colescott
approved these changes
Sep 7, 2021
stylewarning
force-pushed
the
nicer-lexicals
branch
from
850075a
to
8ab5194
Compare
Also add a :TYPE and :DOCUMENTATION option to DEFINE-GLOBAL-LEXICAL.
stylewarning
force-pushed
the
nicer-lexicals
branch
from
8ab5194
to
f922f63
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a
:TYPEand:DOCUMENTATIONoption toDEFINE-GLOBAL-LEXICAL.In principle, this is optimizing in the same way
serapeum:defdoes, but this works in our use-case. (See issue #54.)This will ostensibly make Coalton code faster, but I didn't benchmark.