-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing tests #385
Fix failing tests #385
Conversation
Pull Request Test Coverage Report for Build 9710474884Details
💛 - Coveralls |
Apparently, it's only two tests that are broken under Node 20. I will look into how to solve the problem here. |
6fa2386
to
1c6a54f
Compare
overlaps replaces #362 ? |
Hmm, good point! Maybe updating will actually solve the issue here – I will test it out :) |
36539be
to
19e03de
Compare
I think this PR is now ready for review :) The tests are passing now again (I also added Node 22 to the test matrix) – however, I needed to skip a few of them since there seem to be some changes in Node 20 and above that cause issues with In general, the tests are somewhat flaky at the moment, but I think we can probably deal with that in future PRs. For now, it is probably more important to be able to move forward again (and maybe also release a new version). |
This PR will investigate and hopefully eventually solve the issues we currently observe when it comes to testing the library.