Refactoring Document, Rustfmt #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LucioFranco can you take a quick look and merge if it looks ok to you? :) |
| @@ -158,7 +154,7 @@ pub fn build(config: &Config) -> Result<()> { | |||
| } | |||
|
|
|||
| try!(fs::copy(entry.path(), &dest.join(relative)) | |||
| .map_err(|_| format!("Could not copy {:?}", entry.path()))); | |||
| .map_err(|_| format!("Could not copy {:?}", entry.path()))); | |||
There was a problem hiding this comment.
I know you didn't change this in this PR but should we not tell the user what the error was. Like permissions?
There was a problem hiding this comment.
you're right, I'll take a look
This solves some potential issues and code mess in document.rs, e.g. having duplicated calls to get_attributes() and setting attributes in different places. I also did a Rustfmt.
|
@LucioFranco updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves some potential issues and code mess in document.rs, e.g.
having duplicated calls to get_attributes() and setting attributes in
different places.
I also did a Rustfmt.