-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UTM important dates scraper #81
Conversation
added initial scraping code
This reverts commit 13fdda0.
Added basic scraping code
the scraper and now functional, but the JSON file names may have to be changed
fixed bug and added more comments
Update date format to match ISO 8601 format
Can you squash your first 3 commits and capitalize the message? 😬 |
def scrape(location='.'): | ||
def scrape(location='.', year=None): #scrapes most current sessions by default | ||
|
||
year = year or now.year |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call datetime.datetime.now()
here instead if it's needed.
|
Thanks, I'll try and implement the fixes. Btw, how do I make changes to the commit messages and "squash" the first 3? Still learning how to use git sorry about that. |
@anderson202 don't worry about that, I can squash them when I merge this to I'll try to review this tomorrow as well. |
@kshvmdn +1 to the |
git rebase -i head~5 |
Removed unnecessary lines and implemented suggested fixes
I've implemented a few of the suggested fixes. Not sure if some of the other suggestions was necessary, please let me know if they are or if any more changes are required. |
def scrape(location='.'): | ||
def scrape(location='.', year=None): #scrapes most current sessions by default | ||
|
||
year = year or datetime.datetime.now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
year = year or datetime.datetime.now().year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kshvmdn sorry about that, fixed now thanks.
Looks pretty good! There could be a few formatting changes to better follow PEP8, but that can be done at a later point. |
One thing that should be changed though is moving it to a |
Finally got the chance to try this - it looks good! I found some other small stuff that we may be able to improve on:
Other than that, I think this is really good! |
Got it, will get them done ASAP. |
@kshvmdn good to merge? |
@kshvmdn that's fine then. @anderson202 thanks a lot for contributing. It's the work that people like you put into this that really pushes the project forward. |
Implemented UTM important dates scraper