Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing <searchlist></searchlist> tag in autoyast.xml even if name_servers_list is empty #2628

Closed
bruncsak opened this issue May 7, 2021 · 3 comments · Fixed by #2629
Closed
Labels
3.2.0 Release 3.2.0 Bug Report Reporting a bug
Milestone

Comments

@bruncsak
Copy link
Contributor

bruncsak commented May 7, 2021

Describe the bug

When installing tumbleweed, yast2 complains about syntax error in the autoyast.xml.
It looks like that

<searchlist config:type="list">
</searchlist>

is printed into autoyast.xml, even if the name_servers_list array is empty.

Steps to reproduce

I believe any suse breed system with empty name_servers_list would produce an autoyast.xml file having the empty list in between the <searchlist> and </searchlist> tags; based on the sample_autoyast.xml template, which is relying on the networking.xml snippet.

Expected behavior

No searchlist tags are printed if the name_servers_list variable is empty.

Cobbler version

cobbler-3.2.0-2.module_el8+10474+71f42bad.noarch

Operating system

CentOS Stream release 8
@bruncsak bruncsak added the Bug Report Reporting a bug label May 7, 2021
@SchoolGuy SchoolGuy added the 3.2.0 Release 3.2.0 label May 7, 2021
@SchoolGuy SchoolGuy added this to the v3.3.0 milestone May 7, 2021
@SchoolGuy
Copy link
Member

Feel free to open a PR. This is purely templating related. So feel free to open a PR, I would be willing to help you. Here a pointer to the file which I think is related:

<searchlist config:type="list">

I would have expected with the wrapped ifVar that this is already taken care of.

@bruncsak
Copy link
Contributor Author

bruncsak commented May 7, 2021

Here is the pull request: #2629

@nodeg
Copy link
Member

nodeg commented May 10, 2021

Fixed with #2629. Thank you for the contribution @bruncsak.

@nodeg nodeg closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 Release 3.2.0 Bug Report Reporting a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants