Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up various PhantomJS hacks #8275

Merged
merged 5 commits into from
Dec 18, 2017
Merged

Clean up various PhantomJS hacks #8275

merged 5 commits into from
Dec 18, 2017

Commits on Dec 15, 2017

  1. Revert "systemd: Hack to stop phantomjs from crashing" 

    This reverts commit 7958040.
    @martinpitt
    martinpitt committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    cb06862 View commit details
    Browse the repository at this point in the history

  2. Drop remaining phantom checkpoints 

    These are not being used any more by our test machinery with chromium,
so this is just dead code now.
    @martinpitt
    martinpitt committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    ae57fe6 View commit details
    Browse the repository at this point in the history

  3. test: Clean up and simplify key presses 

    Chromium does not use long key names like "Return", but we use
`type="char"` for everything. Drop the compatibility shim for rewriting
`Return` to `\r` and update tests to use `\r` directly.

As iterating over a string iterates over its characters, change
`key_press()` invocations to just pass a string with all desired
characters, for better readability.
    @martinpitt
    martinpitt committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    d4f9cd4 View commit details
    Browse the repository at this point in the history

  4. bots: Drop PhantomJS crash retries from tests-policy 

    We don't currently expect something similar with Chromium.
    @martinpitt
    martinpitt committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    1b71278 View commit details
    Browse the repository at this point in the history

  5. Drop various PhantomJS hacks 

    Closes cockpit-project#8275
    @martinpitt
    martinpitt committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    e2f34a4 View commit details
    Browse the repository at this point in the history