Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PGURL nil check from testserver docs #105

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Jun 3, 2021

NewTestServer performs the check so it is redundant.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@0xmohit
Copy link
Contributor Author

0xmohit commented Jun 4, 2021

cc: @rafiss

@rafiss
Copy link
Contributor

rafiss commented Jun 4, 2021

Hmm it looks like an upstream change is causing this to fail. I'll investigate further

@rafiss
Copy link
Contributor

rafiss commented Jun 4, 2021

filed #106

@rafiss
Copy link
Contributor

rafiss commented Jun 4, 2021

@0xmohit can you rebase your changes and force-push? it should be fixed now

NewTestServer performs the check so it is redundant.
@0xmohit
Copy link
Contributor Author

0xmohit commented Jun 5, 2021

@rafiss Done.

Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

@rafiss rafiss merged commit 60331c9 into cockroachdb:master Jun 5, 2021
@0xmohit 0xmohit deleted the docs branch June 5, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants