testserver: use glibc binary on systems with eglibc #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of Ubuntu use eglibc ("embedded glibc") instead of glibc,
so they don't match the glibc regex. Attempting to run the musl
binaries on these systems hangs forever. (We should probably look into
this separately; the musl binaries should work on these systems.) For
now, though, work around the issue by grepping for the less-common
"musl" rather than glibc.
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
From slack, for posterity: Thanks for finding and fixing this! The reason I was looking for gnu is that musl is fully static and should run anywhere. Bummer that it hangs, good thing we're not publishing those binaries anywhere. We should flip the logic when the musl build actually works though. I think this is jemalloc/jemalloc#585. Filed as #32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of Ubuntu use eglibc ("embedded glibc") instead of glibc,
so they don't match the glibc regex. Attempting to run the musl
binaries on these systems hangs forever. (We should probably look into
this separately; the musl binaries should work on these systems.) For
now, though, work around the issue by grepping for the less-common
"musl" rather than "glibc."
This change is