Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: switch to regional buckets in GCE; MR is no longer free wrt egress #111371

Closed
srosenberg opened this issue Sep 27, 2023 · 2 comments
Closed
Assignees
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@srosenberg
Copy link
Member

srosenberg commented Sep 27, 2023

As of last year, GCE decided to charge for egress, when reading from a multi-regional (MR) bucket [1]. AWS' s3 doesn't even support multi-regional buckets. (Technically, it supports cross-regional replication, but the bucket is always pinned to a specific region.) In light of the above, we are going to stick with regional buckets for roachtest, across all providers. The reduction in egress (cost) also facilitates better resource load-balancing across regions; e.g., our local SSD quota has been steadily running low in us-east1, while the request to increase it, continues to linger; moving a small percentage of clusters to us-central1 alleviates the quota issue.

[1]https://cloud.google.com/storage/pricing-announce#network

Jira issue: CRDB-31875

@srosenberg srosenberg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-testeng TestEng Team labels Sep 27, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 27, 2023

cc @cockroachdb/test-eng

@blathers-crl blathers-crl bot added this to Triage in Test Engineering Sep 27, 2023
@msbutler msbutler self-assigned this Sep 27, 2023
msbutler added a commit to msbutler/cockroach that referenced this issue Oct 31, 2023
This weekly test is very costly (leads to cross region egress) and is already
run on aws. We can reconsider unskipping it after cockroachdb#111371 is addressed.

Epic: none

Release note: none
craig bot pushed a commit that referenced this issue Oct 31, 2023
112106: server: add tests for combined stmts api source tables r=maryliag a=xinhaoz

This patch creates the sqlstatstestutils pkg in
sqlstats/persistedsqlstats.  It moves the function
`GetRandomizedCollectedStatementStatisticsForTest` which was
previously in sqlstatsutil. This pkg is introduced in
preparation for adding more testing utilities to mock sql
stats tables without creating cyclic dependencies with
sqlstatsutil.

Epic: none

Release note: None

### 2: [server: add tests for combined stmts api](1bf95c1)

Add testing to verify that the combined stmts api uses the
correct source tables given different table states.

Epic: none

112990: kvserver: setup ranges in large unsplittable replicate test r=andrewbaptist a=kvoli

`TestLargeUnsplittableRangeReplicate` would fail when the SQL query to
show the table's replicas returned no results for the unsplittable range
being tested. No results would be returned when the table split was
delayed.

Update the test to insert a split at the first row, as well as the
existing split at the second row. This avoids the first range starting
with 5 replicas and the test's reliance on timely span config splits.

The previous deflake attempt is reverted.

Resolves: #112774
Release note: None

113500: roachtest: skip restore/tpce/32TB/inc-count=400/gce/nodes=15/cpus=16 r=msbutler a=msbutler

This weekly test is very costly (leads to cross region egress) and is already
run on aws. We can reconsider unskipping it after #111371 is addressed.

Epic: none

Release note: none

Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com>
Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
msbutler added a commit to msbutler/cockroach that referenced this issue Dec 8, 2023
craig bot pushed a commit that referenced this issue Dec 11, 2023
114853: workload/schemachange: update and disable `ALTER TYPE DROP VALUE` r=Xiang-Gu a=chrisseto

#### 31a2ac9 workload/schemachange: update and disable `ALTER TYPE DROP VALUE`

Previously, `ALTER TYPE DROP VALUE` was using the procedural generation
that is most common in this workload.

The desire to add support UDFs required revisiting the implement as
referenced enum values cannot be dropped.

Unfortunately, there is not a straightforward way to determine if a
specific enum is being referenced by other descriptors (namely default
expressions for columns and UDFs).

After the initial update and a few testing rounds with UDF support, a
bug between enums and UDFs was discovered. (See #114844 for details).

This commit upgrades the implementation of `ALTER TYPE DROP VALUE` to
utilize the `Generate` helper and dodge cases of referenced enum values.

Due to the aforementioned bug and another outstanding flake, this commit
also disabled `ALTER TYPE DROP VALUE` to prevent further flakes an
noise.

Epic: CRDB-19168
Informs: #113859, #114844
Release note: None

115677: roachtest: replace gs://cockroach-fixtures with gs://cockroach-fixtures-us-east1 r=srosenberg a=msbutler


Informs #111371

Release note: none

116072: pgwirecancel: deflake TestCancelCopyTo r=rafiss a=rafiss

This test had a race condition since it used the same err variable in different goroutines.

fixes #116032
Release note: None

Co-authored-by: Chris Seto <chriskseto@gmail.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
DarrylWong pushed a commit to DarrylWong/fork that referenced this issue Dec 11, 2023
msbutler added a commit to msbutler/cockroach that referenced this issue Dec 16, 2023
msbutler added a commit to msbutler/cockroach that referenced this issue Dec 21, 2023
msbutler added a commit to msbutler/cockroach that referenced this issue Dec 21, 2023
msbutler added a commit to msbutler/cockroach that referenced this issue Dec 28, 2023
msbutler added a commit to msbutler/cockroach that referenced this issue Jan 4, 2024
@msbutler
Copy link
Collaborator

msbutler commented Jan 9, 2024

fixture migration has complete and old bucket has been deleted. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
Development

No branches or pull requests

2 participants