Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add timeseries metric for sum of zombie sstable sizes #122110

Closed
jbowens opened this issue Apr 10, 2024 · 0 comments · Fixed by #122152
Closed

storage: add timeseries metric for sum of zombie sstable sizes #122110

jbowens opened this issue Apr 10, 2024 · 0 comments · Fixed by #122152
Assignees
@jbowens
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
(Deprecated) Storage

Comments

@jbowens
Copy link
Collaborator

jbowens commented Apr 10, 2024 •
edited by cockroach-jira-scripts
Loading

With the introduction of 'eventually file-only snapshots,' long-running operations like the consistency checker or snapshot sending may hold a reference on a LSM read state for a long duration (eg, seconds). This can prevent the reclamation of disk space. We anticipate resolving this in the next release through cockroachdb/pebble#3500.

Informs #121935

Jira issue: CRDB-37708
@jbowens jbowens added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-storage Relating to our storage engine (Pebble) on-disk storage. T-storage Storage Team labels Apr 10, 2024
@blathers-crl blathers-crl bot added this to Incoming in (Deprecated) Storage Apr 10, 2024
@jbowens jbowens mentioned this issue Apr 10, 2024
Closed
@jbowens jbowens moved this from Incoming to In Progress (this milestone) in (Deprecated) Storage Apr 10, 2024
@jbowens jbowens self-assigned this Apr 10, 2024
@jbowens jbowens mentioned this issue Apr 10, 2024
Merged
craig bot pushed a commit that referenced this issue Apr 11, 2024
@jbowens
Merge #122152
9a247ec 
122152: kvserver: add storage.sstable.zombie.bytes metric r=RaduBerinde a=jbowens

Add a new timeseries metric that provides visibility into the volume of data that exists in sstables that are not part of the most recent version of the LSM.

Epic: none
Informs #121935.
Informs #122139.
Informs cockroachdb/pebble#3500.
Close #122110.
Release note (ops change): Adds a new timeseries metric storage.sstable.zombie.bytes.

Co-authored-by: Jackson Owens <jackson@cockroachlabs.com>
@craig craig bot closed this as completed in 39d2395 Apr 11, 2024
(Deprecated) Storage automation moved this from In Progress (this milestone) to Done Apr 11, 2024
blathers-crl bot pushed a commit that referenced this issue Apr 11, 2024
@jbowens
kvserver: add storage.sstable.zombie.bytes metric
2356a71 
Add a new timeseries metric that provides visibility into the volume of data
that exists in sstables that are not part of the most recent version of the
LSM.

Epic: none
Informs #121935.
Informs #122139.
Informs cockroachdb/pebble#3500.
Close #122110.
Release note (ops change): Adds a new timeseries metric
storage.sstable.zombie.bytes.
@blathers-crl blathers-crl bot mentioned this issue Apr 11, 2024
Merged
andrew-delph pushed a commit to andrew-delph/cockroach that referenced this issue Jun 20, 2024
@jbowens @andrew-delph
kvserver: add storage.sstable.zombie.bytes metric
3f8248e 
Add a new timeseries metric that provides visibility into the volume of data
that exists in sstables that are not part of the most recent version of the
LSM.

Epic: none
Informs cockroachdb#121935.
Informs cockroachdb#122139.
Informs cockroachdb/pebble#3500.
Close cockroachdb#122110.
Release note (ops change): Adds a new timeseries metric
storage.sstable.zombie.bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbowens jbowens

Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
Storage
Archived in project
(Deprecated) Storage
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: add storage.sstable.zombie.bytes metric jbowens/cockroach
1 participant
@jbowens