kvserver: add storage.sstable.zombie.bytes metric #122152
Conversation
Add a new timeseries metric that provides visibility into the volume of data that exists in sstables that are not part of the most recent version of the LSM. Epic: none Informs cockroachdb#121935. Informs cockroachdb#122139. Informs cockroachdb/pebble#3500. Close cockroachdb#122110. Release note (ops change): Adds a new timeseries metric storage.sstable.zombie.bytes.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @itsbilal and @jbowens)
pkg/kv/kvserver/metrics.go line 3736 at r1 (raw file):
sm.BatchCommitWALRotWaitDuration.Update(int64(m.BatchCommitStats.WALRotationDuration)) sm.BatchCommitCommitWaitDuration.Update(int64(m.BatchCommitStats.CommitWaitDuration)) sm.SSTableZombieBytes.Update(int64(m.Table.ZombieSize))
.Table.Local.ZombieSize
There was a problem hiding this comment.
Reviewable status:
pkg/kv/kvserver/metrics.go line 3736 at r1 (raw file):
Previously, RaduBerinde wrote…
.Table.Local.ZombieSize
I debated this and thought we'd prefer the wider, more all-encompassing one. Even with disaggregated storage, we may care about zombie sstables in blob storage.
There was a problem hiding this comment.
Reviewable status:
pkg/kv/kvserver/metrics.go line 3736 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
I debated this and thought we'd prefer the wider, more all-encompassing one. Even with disaggregated storage, we may care about zombie sstables in blob storage.
👍
|
TFTR! bors r=RaduBerinde |
Add a new timeseries metric that provides visibility into the volume of data that exists in sstables that are not part of the most recent version of the LSM.
Epic: none
Informs #121935.
Informs #122139.
Informs cockroachdb/pebble#3500.
Close #122110.
Release note (ops change): Adds a new timeseries metric storage.sstable.zombie.bytes.