Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: bounded EFOS pinning #122139

Open
jbowens opened this issue Apr 10, 2024 · 0 comments
Open

storage: bounded EFOS pinning #122139

jbowens opened this issue Apr 10, 2024 · 0 comments
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team

Comments

@jbowens
Copy link
Collaborator

jbowens commented Apr 10, 2024

Cockroach repository companion issue for cockroachdb/pebble#3500. Now that we use "eventually file-only snapshots," we're more susceptible to space amplification from long-running operations that keep an iterator version pinned. To reduce the space amplification, we can take advantage of an EFOS's bounds to only pin sstables that the EFOS will read.

Jira issue: CRDB-37724

Epic CRDB-37583

@jbowens jbowens added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-storage Relating to our storage engine (Pebble) on-disk storage. T-storage Storage Team labels Apr 10, 2024
@blathers-crl blathers-crl bot added this to Incoming in (Deprecated) Storage Apr 10, 2024
jbowens added a commit to jbowens/cockroach that referenced this issue Apr 10, 2024
Add a new timeseries metric that provides visibility into the volume of data
that exists in sstables that are not part of the most recent version of the
LSM.

Epic: none
Informs cockroachdb#121935.
Informs cockroachdb#122139.
Informs cockroachdb/pebble#3500.
Close cockroachdb#122110.
Release note (ops change): Adds a new timeseries metric
storage.sstable.zombie.bytes.
craig bot pushed a commit that referenced this issue Apr 11, 2024
122152: kvserver: add storage.sstable.zombie.bytes metric r=RaduBerinde a=jbowens

Add a new timeseries metric that provides visibility into the volume of data that exists in sstables that are not part of the most recent version of the LSM.

Epic: none
Informs #121935.
Informs #122139.
Informs cockroachdb/pebble#3500.
Close #122110.
Release note (ops change): Adds a new timeseries metric storage.sstable.zombie.bytes.

Co-authored-by: Jackson Owens <jackson@cockroachlabs.com>
blathers-crl bot pushed a commit that referenced this issue Apr 11, 2024
Add a new timeseries metric that provides visibility into the volume of data
that exists in sstables that are not part of the most recent version of the
LSM.

Epic: none
Informs #121935.
Informs #122139.
Informs cockroachdb/pebble#3500.
Close #122110.
Release note (ops change): Adds a new timeseries metric
storage.sstable.zombie.bytes.
@nicktrav nicktrav moved this from Incoming to 24.2 candidates in (Deprecated) Storage Apr 16, 2024
andrew-delph pushed a commit to andrew-delph/cockroach that referenced this issue Jun 20, 2024
Add a new timeseries metric that provides visibility into the volume of data
that exists in sstables that are not part of the most recent version of the
LSM.

Epic: none
Informs cockroachdb#121935.
Informs cockroachdb#122139.
Informs cockroachdb/pebble#3500.
Close cockroachdb#122110.
Release note (ops change): Adds a new timeseries metric
storage.sstable.zombie.bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
Status: 24.2 candidates
(Deprecated) Storage
  
24.2 candidates
Development

No branches or pull requests

1 participant