New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teamcity: failed test: TestChangefeedSchemaChangeAllowBackfill #33166
Comments
I'm investigating this failure as part of #29569. |
I think something is getting wedged in this test. We give the
Something strange from the stack traces is that I can't find a goroutine still running the test. I do see a goroutine stuck in
Is something not getting shut down correctly? |
This looks like the offending goroutine:
|
More precisely:
I'm not seeing anything here that looks for the stopper to be shut down. |
Any goroutine started via `Stopper.RunAsyncTask` needs to watch `Stopper.ShouldQuiesce()` to determine if it should stop processing. This wasn't being done properly for the "changefeed-poller" task causing the test to fail to exit in rare circumstances. Fixes cockroachdb#33166 Release note: None
Fix two related deadlocks in rangefeed teardown. The error channel (`errC`) used by `Processor.Register` to indicate a rangefeed processor is closed needs to be buffered because the caller of `Processor.Register` is the reader of this channel. Similarly, we need to consider that processing might have already placed on error on `errC` and that a reader might never read the "closed" error that `Processor.Register` is trying to send. Fixes cockroachdb#33166 Release note: None
33303: storage: fix a deadlock in rangefeed teardown r=mrtracy a=petermattis Fix two related deadlocks in rangefeed teardown. The error channel (`errC`) used by `Processor.Register` to indicate a rangefeed processor is closed needs to be buffered because the caller of `Processor.Register` is the reader of this channel. Similarly, we need to consider that processing might have already placed on error on `errC` and that a reader might never read the "closed" error that `Processor.Register` is trying to send. Fixes #33166 Release note: None Co-authored-by: Peter Mattis <petermattis@gmail.com>
The following tests appear to have failed on master (testrace): TestChangefeedSchemaChangeAllowBackfill/rangefeed/drop_column, TestChangefeedSchemaChangeAllowBackfill/enterprise/drop_column, TestChangefeedSchemaChangeAllowBackfill/sinkless/multiple_alters, TestChangefeedSchemaChangeAllowBackfill/sinkless/add_column_with_default, TestChangefeedSchemaChangeAllowBackfill/enterprise/add_column_with_default, TestChangefeedSchemaChangeAllowBackfill/rangefeed/multiple_alters, TestChangefeedSchemaChangeAllowBackfill/rangefeed/add_column_computed, TestChangefeedSchemaChangeAllowBackfill/sinkless/add_column_computed, TestChangefeedSchemaChangeAllowBackfill/enterprise, TestChangefeedSchemaChangeAllowBackfill/rangefeed, TestChangefeedSchemaChangeAllowBackfill/enterprise/multiple_alters, TestChangefeedSchemaChangeAllowBackfill/rangefeed/add_column_with_default, TestChangefeedSchemaChangeAllowBackfill, TestChangefeedSchemaChangeAllowBackfill/sinkless/drop_column, TestChangefeedSchemaChangeAllowBackfill/enterprise/add_column_computed, TestChangefeedSchemaChangeAllowBackfill/sinkless
You may want to check for open issues.
#1056354:
Please assign, take a look and update the issue accordingly.
The text was updated successfully, but these errors were encountered: