storage: fix a deadlock in rangefeed teardown #33303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two related deadlocks in rangefeed teardown. The error channel (`errC`) used by `Processor.Register` to indicate a rangefeed processor is closed needs to be buffered because the caller of `Processor.Register` is the reader of this channel. Similarly, we need to consider that processing might have already placed on error on `errC` and that a reader might never read the "closed" error that `Processor.Register` is trying to send. Fixes cockroachdb#33166 Release note: None
|
This change is |
|
Ping. Anyone around to review this beauty? It's pretty trivial. |
mrtracy
approved these changes
Dec 20, 2018
|
bors r=mrtracy |
craig bot
pushed a commit
that referenced
this pull request
Dec 20, 2018
33303: storage: fix a deadlock in rangefeed teardown r=mrtracy a=petermattis Fix two related deadlocks in rangefeed teardown. The error channel (`errC`) used by `Processor.Register` to indicate a rangefeed processor is closed needs to be buffered because the caller of `Processor.Register` is the reader of this channel. Similarly, we need to consider that processing might have already placed on error on `errC` and that a reader might never read the "closed" error that `Processor.Register` is trying to send. Fixes #33166 Release note: None Co-authored-by: Peter Mattis <petermattis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two related deadlocks in rangefeed teardown. The error
channel (
errC) used byProcessor.Registerto indicate a rangefeedprocessor is closed needs to be buffered because the caller of
Processor.Registeris the reader of this channel. Similarly, we needto consider that processing might have already placed on error on
errCand that a reader might never read the "closed" error that
Processor.Registeris trying to send.Fixes #33166
Release note: None