ccl/changefeedccl: deflake TestChangefeedSchemaChangeAllowBackfill #33272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
force-pushed
the
pmattis/deflake-changefeed-schemachange-allow-backfill
branch
from
51aa732
to
c31e3e0
Compare
Any goroutine started via `Stopper.RunAsyncTask` needs to watch `Stopper.ShouldQuiesce()` to determine if it should stop processing. This wasn't being done properly for the "changefeed-poller" task causing the test to fail to exit in rare circumstances. Fixes cockroachdb#33166 Release note: None
petermattis
force-pushed
the
pmattis/deflake-changefeed-schemachange-allow-backfill
branch
from
c31e3e0
to
0b1a649
Compare
|
Hold off on reviewing this. I'm pretty sure this is the source of the wedged tests, but the fix needs some more love. |
|
Turns out there was an additional problem: a deadlock in rangefeed processor teardown. I have a fix, just need to stress it for a while. |
|
Turns out that the stopper change wasn't necessary. Closing this in favor of #33303. |
petermattis
deleted the
pmattis/deflake-changefeed-schemachange-allow-backfill
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any goroutine started via
Stopper.RunAsyncTaskneeds to watchStopper.ShouldQuiesce()to determine if it should stopprocessing. This wasn't being done properly for the "changefeed-poller"
task causing the test to fail to exit in rare circumstances.
Fixes #33166
Release note: None