Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli,server: remove the shutdown timeout upon the first SIGTERM #43902

Closed
knz opened this issue Jan 13, 2020 · 0 comments · Fixed by #44074
Closed

cli,server: remove the shutdown timeout upon the first SIGTERM #43902

knz opened this issue Jan 13, 2020 · 0 comments · Fixed by #44074
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented Jan 13, 2020

Currently when one sends SIGTERM to a crdb server, the server starts a graceful shutdown.
If the graceful shutdown does not complete under a minute, the code in cli/start.go further triggers a hard shutdown.

@tbg suggests that we should remove this timeout:

  • task managers [are assumed to send] SIGTERM first and send a SIGKILL if the process doesn’t terminate within whatever timeout the operator has configured for the task manager
  • we’d do a hard shutdown after the second signal, like today, so quitting nodes on the command line remains easy.
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cli labels Jan 13, 2020
@craig craig bot closed this as completed in 48dfebc Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant